GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
9083 commits 6 branches 57 tags 42 MiB
Commit graph

9083 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Beckingham
3eb209f248 Revert "[clang-tidy] Use '' for single characters" 
This reverts commit e3ceda9ce1.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
c3ecfac4f5 Revert "[clang-tidy] Use const reference instead of initializing string" 
This reverts commit ab170e34df.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
7d8fff418e Revert "[clang-tidy] Reserve memory for vector loop" 
This reverts commit 7f86b29aa9.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
702af00435 Revert "[clang-tidy] Remove redundant const" 
This reverts commit 55d103c491.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
c43a513158 Revert "[clang-tidy] Replace C style casts with C++ ones" 
This reverts commit 13e1bf7204.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
364b4ea8bd Revert "[clang-tidy] Simplify boolean expressions" 
This reverts commit 51870dff34.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
623d5ceb59 Revert "[clang-tidy] using dynamic_cast for derived classes" 
This reverts commit a02754159c.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
6ad1b7d0da Revert "[clang-tidy] match loop size with size()" 
This reverts commit 68c446ea08.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
c02e369fbc Revert "[clang-tidy] Cast integer to string" 
This reverts commit da75c159ca.
 2020-12-05 16:18:37 -05:00
Rosen Penev
da75c159ca [clang-tidy] Cast integer to string 
Found with bugprone-string-integer-assignment

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
68c446ea08 [clang-tidy] match loop size with size() 
Found with bugprone-too-small-loop-variable

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
a02754159c [clang-tidy] using dynamic_cast for derived classes 
Found with cppcoreguidelines-pro-type-cstyle-cast

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
51870dff34 [clang-tidy] Simplify boolean expressions 
Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
13e1bf7204 [clang-tidy] Replace C style casts with C++ ones 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
55d103c491 [clang-tidy] Remove redundant const 
Found with readability-const-return-type

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
7f86b29aa9 [clang-tidy] Reserve memory for vector loop 
Found with performance-inefficient-vector-operation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
ab170e34df [clang-tidy] Use const reference instead of initializing string 
Found with performance-unnecessary-copy-initialization

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
e3ceda9ce1 [clang-tidy] Use '' for single characters 
Found with performance-faster-string-find

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
426e067f43 [cl;ang-tidy] Don't initialize strings 
Found with readability-redundant-string-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
cc6826fc3a [clang-tidy] Remove redundant init 
Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
54e40008c9 [clang-tidy] Convert 0/1 to false/true 
Found with modernize-use-bool-literals

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
0344856d65 [clang-tidy] Switch C headers to C++ ones 
Found using modernize-return-braced-init-list

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
e46039efb1 [clang-tidy] Pass by value with std::move 
Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
6cd15235be [clang-tidy] Access static member through qualified-id 
Found readability-static-accessed-through-instance

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
37b641259c [clang-tidy] Add const references where useful 
Found with performance-for-range-copy

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
defd49b13d [clang-tidy] Add const where it makes sense 
Found with readability-redundant-string-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
bf40ea8816 [clang-tidy] Use default to initialize constructors 
Found with modernize-use-equals-default

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
897759e4dc [clang-tidy] Replace push_back with emplace_back 
Found with modernize-use-emplace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
a468537c1b [clang-tidy] Use new range based loops 
Found with modernize-loop-convert

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
6ce2a129dd [clang-tidy] Use auto where the type is known 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
a331cceded [clang-tidy] Use .empty instead of comparing size 
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Tomas Babej
d43fa66489 CmdPurge: Detect the failure mode of trying to purge non-deleted tasks 
Prompted by the failure mode described by Glen Solsberry in #2254.
 2020-12-05 14:31:27 -05:00
Julien Rabinow
e37d932208 bump libshared submodule version 2020-12-05 14:30:58 -05:00
Tomas Babej
ab12e3fafd
CMake: Add custom review target 
Use with Github PR ids as follows:
make PR=2358 review
 2020-12-04 00:20:30 -05:00
Tomas Babej
522ef20a85
scripts: Add a dockerfile to build review images 
This automates the review process of a given PR by checking out the
current HEAD of the given PR and installing TW in a container.
 2020-12-04 00:20:29 -05:00
Max Rossmannek
3d850715f4 Make virtual tags consistent across commands. 
- the DUETODAY tag was deprecated in b2d49f397
- the QUARTER tag was added in 630a1530e and 4711dd9e1
- the PROJECT, PRIORITY and LATEST tags were added in 4008a64

Note: the documentation in the man page is already up-to-date.

Fixes #2359
 2020-12-03 01:45:07 -05:00
Max Rossmannek
4663ca840f Mark failing tests as expected failures 
Related issues:
- TW-1630 (#1654) needs to be re-opened!
- TW-1915 (#1928)
 2020-11-30 01:01:26 -05:00
Max Rossmannek
d85901e7ff Properly escape filters including spaces 
This adds a note to the man page to properly escape filters containing
spaces. It also fixes the unittests to reflect this.

One of the unittests contained an alternative syntax as discussed in
TW-1479 (#1505). It has been extracted into its own unittest and marked
as an expected failure because it is currently not supported.
 2020-11-30 01:01:26 -05:00
Max Rossmannek
09e2cb46d6 Simplify task construction 2020-11-30 01:01:26 -05:00
Max Rossmannek
44bcd58051 Fix Undo command 
The Undo command broke in 48dff11 when the `onModify` hook got added to
its execution in order to fix #2213. The reason for it begin broke is
that a Task object is created in an unsafe manner because the `prior`
task may be empty.
Catching this case fixes the bug.
 2020-11-30 01:01:26 -05:00
Max Rossmannek
50cfd92ad5 Fix Arch docker image 2020-11-30 00:51:54 -05:00
Max Rossmannek
596d681be7 Fix faketime packages 2020-11-30 00:51:54 -05:00
Max Rossmannek
07a27cbd3b Replace libfaketime with faketime in debianstable 
I verified locally that this avoids skipping all of the
faketime-dependent unittests. The Travis CI logs will have to be
investigated for all of the other docker images on which distros we may
need to apply a similar fix.
 2020-11-30 00:51:54 -05:00
Max Rossmannek
61a78d0a6f Attempt greedy docker config update 
This is an attempt at updating all docker configurations by simply
replacing the `python` packages with `python3`. The Travis CI will let
us know if this works.
 2020-11-30 00:51:54 -05:00
Max Rossmannek
8b91cd97a8 Enforce Python 3 in test_hooks/wrapper 
This change was not included in the previous commit because the sed
command I used included the `/usr/bin/env` path to ensure I don't
replace any occurences of the word `python` which I did not wish to
replace.
 2020-11-30 00:51:54 -05:00
Max Rossmannek
f35989be0e Enforce Python 3 for unittests 
This commit updates all tests to enforce the Python3 executable. This is
necessary because the `assertRegex` function we use was renamed to this
name only in Python 3.2 [1]

For reference:
s;/usr/bin/env python;/usr/bin/env python3;g

[1]: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRegex
 2020-11-30 00:51:54 -05:00
Tomas Janousek
2c4d4ad649 Test: Add UUID test demonstrating a "Cannot subtract strings" bug 
$ task 0000000d-000a-0000-0000-000000000000 export
Cannot subtract strings
$ task 0000000d-0000-0000-0000-000000000000 export
The expression could not be evaluated.
 2020-11-24 02:42:32 -05:00
Tomas Babej
a09f9d48ab Update copyright to 2020 2020-11-21 12:27:05 -05:00
Tomas Babej
d81b999fa9 tests: Do not require line buffering 
Test runner complains about it not being supported with binary files and
it does not look like it affects any tests in the first place anyway.
 2020-11-21 12:27:05 -05:00
Tomas Babej
02db131fa1 tests: Use updated unittest method 2020-11-21 12:27:05 -05:00