GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Properly escape filters including spaces

Browse source 
This adds a note to the man page to properly escape filters containing
spaces. It also fixes the unittests to reflect this.

One of the unittests contained an alternative syntax as discussed in
TW-1479 (#1505). It has been extracted into its own unittest and marked
as an expected failure because it is currently not supported.
This commit is contained in:
Max Rossmannek 2020-11-28 14:21:16 +01:00 • committed by Tomas Babej
parent 09e2cb46d6
commit d85901e7ff
4 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
doc/man/task.1.in
View file

@ -75,6 +75,10 @@ UUID numbers or ID ranges):
task 1 2-5 19 modify pri:H
task 4-7 ebeeab00-ccf8-464b-8b58-f7f2d606edfb info
Note that it may be necessary to properly escape special characters as well as
quotes in order to avoid their special meanings in the shell. See also the
section 'SPECIFYING DESCRIPTIONS' for more information.
.SH MODIFICATIONS
The <mods> consist of zero or more changes to apply to the selected tasks, such

2
test/filter.t
View file

@ -670,7 +670,7 @@ class TestBug1600(TestCase):
self.assertIn("foobar1", out)
self.assertIn("foobar2", out)
code, out, err = self.t("all description.contains:'foobar\\+'")
code, out, err = self.t(r"all description.contains:\'foobar\\+\'")
self.assertIn("foobar+", out)
self.assertNotIn("foobar1", out)
self.assertNotIn("foobar2", out)

2
test/project.t
View file

@ -464,7 +464,7 @@ class TestBug1617(TestCase):
self.t("add one")
self.t("add two project:'three four'")
code, out, err = self.t("project:'three four' list")
code, out, err = self.t(r"project:\'three\ four\' list")
self.assertIn("two", out)
self.assertNotIn("one", out)

10
test/search.t
View file

@ -254,11 +254,17 @@ class TestBug1479(TestCase):
self.t("add project:P1 one")
self.t("add project:P2 one two")
code, out, err = self.t("description:one\ two list")
code, out, err = self.t(r"description:\'one\ two\' list")
self.assertNotIn("P1", out)
self.assertIn("P2", out)
code, out, err = self.t("description:'one two' list")
@unittest.expectedFailure
def test_description_with_spaces_alternative_syntax(self):
"""1479: Alternative syntax"""
self.t("add project:P1 one")
self.t("add project:P2 one two")
code, out, err = self.t("description:one\ two list")
self.assertNotIn("P1", out)
self.assertIn("P2", out)