Tomas Babej
642f250f72
tests: Mark failing corner case tests as expected for 2.6.0
...
These are still important problems, but it will allow us to fully
leverage CI while waiting for the fixes.
2020-12-05 18:24:29 -05:00
Paul Beckingham
3e0a428185
Revert "[clang-tidy] Use .empty instead of comparing size"
...
This reverts commit a331cceded
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
b2d46a1eba
Revert "[clang-tidy] Use auto where the type is known"
...
This reverts commit 6ce2a129dd
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
0a3a4d364d
Revert "[clang-tidy] Use new range based loops"
...
This reverts commit a468537c1b
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
e3e158bf6a
Revert "[clang-tidy] Replace push_back with emplace_back"
...
This reverts commit 897759e4dc
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
ead50d4d6e
Revert "[clang-tidy] Use default to initialize constructors"
...
This reverts commit bf40ea8816
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
aa841f98c9
Revert "[clang-tidy] Add const where it makes sense"
...
This reverts commit defd49b13d
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
2652a9d3f1
Revert "[clang-tidy] Add const references where useful"
...
This reverts commit 37b641259c
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
8cf4e3de08
Revert "[clang-tidy] Access static member through qualified-id"
...
This reverts commit 6cd15235be
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
504aacd244
Revert "[clang-tidy] Pass by value with std::move"
...
This reverts commit e46039efb1
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
5502729131
Revert "[clang-tidy] Switch C headers to C++ ones"
...
This reverts commit 0344856d65
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
444e5955ac
Revert "[clang-tidy] Convert 0/1 to false/true"
...
This reverts commit 54e40008c9
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
0b828be4aa
Revert "[clang-tidy] Remove redundant init"
...
This reverts commit cc6826fc3a
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
9016c26828
Revert "[cl;ang-tidy] Don't initialize strings"
...
This reverts commit 426e067f43
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
3eb209f248
Revert "[clang-tidy] Use '' for single characters"
...
This reverts commit e3ceda9ce1
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
c3ecfac4f5
Revert "[clang-tidy] Use const reference instead of initializing string"
...
This reverts commit ab170e34df
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
7d8fff418e
Revert "[clang-tidy] Reserve memory for vector loop"
...
This reverts commit 7f86b29aa9
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
702af00435
Revert "[clang-tidy] Remove redundant const"
...
This reverts commit 55d103c491
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
c43a513158
Revert "[clang-tidy] Replace C style casts with C++ ones"
...
This reverts commit 13e1bf7204
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
364b4ea8bd
Revert "[clang-tidy] Simplify boolean expressions"
...
This reverts commit 51870dff34
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
623d5ceb59
Revert "[clang-tidy] using dynamic_cast for derived classes"
...
This reverts commit a02754159c
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
6ad1b7d0da
Revert "[clang-tidy] match loop size with size()"
...
This reverts commit 68c446ea08
.
2020-12-05 16:18:37 -05:00
Paul Beckingham
c02e369fbc
Revert "[clang-tidy] Cast integer to string"
...
This reverts commit da75c159ca
.
2020-12-05 16:18:37 -05:00
Rosen Penev
da75c159ca
[clang-tidy] Cast integer to string
...
Found with bugprone-string-integer-assignment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
68c446ea08
[clang-tidy] match loop size with size()
...
Found with bugprone-too-small-loop-variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
a02754159c
[clang-tidy] using dynamic_cast for derived classes
...
Found with cppcoreguidelines-pro-type-cstyle-cast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
51870dff34
[clang-tidy] Simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
13e1bf7204
[clang-tidy] Replace C style casts with C++ ones
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
55d103c491
[clang-tidy] Remove redundant const
...
Found with readability-const-return-type
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
7f86b29aa9
[clang-tidy] Reserve memory for vector loop
...
Found with performance-inefficient-vector-operation
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
ab170e34df
[clang-tidy] Use const reference instead of initializing string
...
Found with performance-unnecessary-copy-initialization
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
e3ceda9ce1
[clang-tidy] Use '' for single characters
...
Found with performance-faster-string-find
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
426e067f43
[cl;ang-tidy] Don't initialize strings
...
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
cc6826fc3a
[clang-tidy] Remove redundant init
...
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
54e40008c9
[clang-tidy] Convert 0/1 to false/true
...
Found with modernize-use-bool-literals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
0344856d65
[clang-tidy] Switch C headers to C++ ones
...
Found using modernize-return-braced-init-list
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
e46039efb1
[clang-tidy] Pass by value with std::move
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
6cd15235be
[clang-tidy] Access static member through qualified-id
...
Found readability-static-accessed-through-instance
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
37b641259c
[clang-tidy] Add const references where useful
...
Found with performance-for-range-copy
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
defd49b13d
[clang-tidy] Add const where it makes sense
...
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
bf40ea8816
[clang-tidy] Use default to initialize constructors
...
Found with modernize-use-equals-default
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
897759e4dc
[clang-tidy] Replace push_back with emplace_back
...
Found with modernize-use-emplace
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
a468537c1b
[clang-tidy] Use new range based loops
...
Found with modernize-loop-convert
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
6ce2a129dd
[clang-tidy] Use auto where the type is known
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
a331cceded
[clang-tidy] Use .empty instead of comparing size
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Tomas Babej
d43fa66489
CmdPurge: Detect the failure mode of trying to purge non-deleted tasks
...
Prompted by the failure mode described by Glen Solsberry in #2254 .
2020-12-05 14:31:27 -05:00
Julien Rabinow
e37d932208
bump libshared submodule version
2020-12-05 14:30:58 -05:00
Tomas Babej
ab12e3fafd
CMake: Add custom review target
...
Use with Github PR ids as follows:
make PR=2358 review
2020-12-04 00:20:30 -05:00
Tomas Babej
522ef20a85
scripts: Add a dockerfile to build review images
...
This automates the review process of a given PR by checking out the
current HEAD of the given PR and installing TW in a container.
2020-12-04 00:20:29 -05:00
Max Rossmannek
3d850715f4
Make virtual tags consistent across commands.
...
- the DUETODAY tag was deprecated in b2d49f397
- the QUARTER tag was added in 630a1530e
and 4711dd9e1
- the PROJECT, PRIORITY and LATEST tags were added in 4008a64
Note: the documentation in the man page is already up-to-date.
Fixes #2359
2020-12-03 01:45:07 -05:00