Commit graph

11302 commits

Author SHA1 Message Date
Rosen Penev
defd49b13d [clang-tidy] Add const where it makes sense
Found with readability-redundant-string-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
bf40ea8816 [clang-tidy] Use default to initialize constructors
Found with modernize-use-equals-default

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
897759e4dc [clang-tidy] Replace push_back with emplace_back
Found with modernize-use-emplace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
a468537c1b [clang-tidy] Use new range based loops
Found with modernize-loop-convert

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
6ce2a129dd [clang-tidy] Use auto where the type is known
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Rosen Penev
a331cceded [clang-tidy] Use .empty instead of comparing size
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-05 15:03:43 -05:00
Tomas Babej
d43fa66489 CmdPurge: Detect the failure mode of trying to purge non-deleted tasks
Prompted by the failure mode described by Glen Solsberry in #2254.
2020-12-05 14:31:27 -05:00
Julien Rabinow
e37d932208 bump libshared submodule version 2020-12-05 14:30:58 -05:00
Tomas Babej
ab12e3fafd
CMake: Add custom review target
Use with Github PR ids as follows:
make PR=2358 review
2020-12-04 00:20:30 -05:00
Tomas Babej
522ef20a85
scripts: Add a dockerfile to build review images
This automates the review process of a given PR by checking out the
current HEAD of the given PR and installing TW in a container.
2020-12-04 00:20:29 -05:00
Max Rossmannek
3d850715f4 Make virtual tags consistent across commands.
- the DUETODAY tag was deprecated in b2d49f397
- the QUARTER tag was added in 630a1530e and 4711dd9e1
- the PROJECT, PRIORITY and LATEST tags were added in 4008a64

Note: the documentation in the man page is already up-to-date.

Fixes #2359
2020-12-03 01:45:07 -05:00
Max Rossmannek
4663ca840f Mark failing tests as expected failures
Related issues:
- TW-1630 (#1654) needs to be re-opened!
- TW-1915 (#1928)
2020-11-30 01:01:26 -05:00
Max Rossmannek
d85901e7ff Properly escape filters including spaces
This adds a note to the man page to properly escape filters containing
spaces. It also fixes the unittests to reflect this.

One of the unittests contained an alternative syntax as discussed in
TW-1479 (#1505). It has been extracted into its own unittest and marked
as an expected failure because it is currently not supported.
2020-11-30 01:01:26 -05:00
Max Rossmannek
09e2cb46d6 Simplify task construction 2020-11-30 01:01:26 -05:00
Max Rossmannek
44bcd58051 Fix Undo command
The Undo command broke in 48dff11 when the `onModify` hook got added to
its execution in order to fix #2213. The reason for it begin broke is
that a Task object is created in an unsafe manner because the `prior`
task may be empty.
Catching this case fixes the bug.
2020-11-30 01:01:26 -05:00
Leo
643166a337 Uncoditionally include errno.h instead of guessing
POSIX tells us that it is errno.h, musl fails to build with -Werror
because it redirects sys/errno.h->errno.h and uses #warning

(cherry picked from commit 041248e7cc)
2020-11-30 00:53:20 -05:00
John Nguyen
4c714e10a3 Fix typo in man page
The example for _unique has typo, should be using attribute for project.
Fixes #2277

(cherry picked from commit cf45f28cc0)
2020-11-30 00:53:20 -05:00
Max Rossmannek
50cfd92ad5 Fix Arch docker image 2020-11-30 00:51:54 -05:00
Max Rossmannek
596d681be7 Fix faketime packages 2020-11-30 00:51:54 -05:00
Max Rossmannek
07a27cbd3b Replace libfaketime with faketime in debianstable
I verified locally that this avoids skipping all of the
faketime-dependent unittests. The Travis CI logs will have to be
investigated for all of the other docker images on which distros we may
need to apply a similar fix.
2020-11-30 00:51:54 -05:00
Max Rossmannek
61a78d0a6f Attempt greedy docker config update
This is an attempt at updating all docker configurations by simply
replacing the `python` packages with `python3`. The Travis CI will let
us know if this works.
2020-11-30 00:51:54 -05:00
Max Rossmannek
8b91cd97a8 Enforce Python 3 in test_hooks/wrapper
This change was not included in the previous commit because the sed
command I used included the `/usr/bin/env` path to ensure I don't
replace any occurences of the word `python` which I did not wish to
replace.
2020-11-30 00:51:54 -05:00
Max Rossmannek
f35989be0e Enforce Python 3 for unittests
This commit updates all tests to enforce the Python3 executable. This is
necessary because the `assertRegex` function we use was renamed to this
name only in Python 3.2 [1]

For reference:
s;/usr/bin/env python;/usr/bin/env python3;g

[1]: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRegex
2020-11-30 00:51:54 -05:00
Dustin J. Mitchell
8f5e299077 Merge remote-tracking branch 'upstream/main' into main 2020-11-29 21:27:35 -05:00
Dustin J. Mitchell
de03209285 bits of docs 2020-11-29 21:26:39 -05:00
Dustin J. Mitchell
0d5635f092
Update RELEASING.md 2020-11-29 21:10:49 -05:00
Dustin J. Mitchell
8601c0cb67 update Cargo.lock 2020-11-29 21:09:28 -05:00
Dustin J. Mitchell
a1747546d6
Update RELEASING.md 2020-11-29 21:09:22 -05:00
Dustin J. Mitchell
e6abfc5f56 more RELEASING stuff 2020-11-29 20:59:52 -05:00
Dustin J. Mitchell
451690afb7 v0.2.0 2020-11-29 20:59:09 -05:00
Dustin J. Mitchell
17a13e0de9
Merge pull request #78 from djmitche/issue49
Add release stuff
2020-11-29 20:49:18 -05:00
Dustin J. Mitchell
0e2e60372d release process 2020-11-29 20:42:10 -05:00
Dustin J. Mitchell
95ada3d2bb Add metadata for the taskchampion crate 2020-11-29 20:35:25 -05:00
Dustin J. Mitchell
81cee8d375 use CARGO_PKG_VERSION for version 2020-11-29 20:35:25 -05:00
Dustin J. Mitchell
dd01c985ec fix typo 2020-11-29 20:34:59 -05:00
Dustin J. Mitchell
8f361c28b7 remove unnecessary warning suppression 2020-11-29 20:34:43 -05:00
Dustin J. Mitchell
89a0071136
Merge pull request #77 from djmitche/issue49
Add a getting-started section
2020-11-29 20:24:47 -05:00
Dustin J. Mitchell
08faac957a Add a getting-started section 2020-11-29 20:14:06 -05:00
Dustin J. Mitchell
33283658d5
Merge pull request #75 from djmitche/issue54
use log and env_logger, and add some logging around sync
2020-11-29 18:34:01 -05:00
Dustin J. Mitchell
0a1ee470f7 use log and env_logger, and add some logging around sync 2020-11-29 18:18:28 -05:00
Dustin J. Mitchell
c117494ce6
Merge pull request #74 from djmitche/issue66
Implement actual on-disk storage for sync-server.
2020-11-29 17:47:11 -05:00
Dustin J. Mitchell
8b233de46e
Merge pull request #73 from djmitche/issue72
Add done and delete subcommands
2020-11-29 17:42:02 -05:00
Dustin J. Mitchell
786d5b6a17 Implement actual on-disk storage for sync-server. 2020-11-29 17:41:28 -05:00
Dustin J. Mitchell
1b7dbd0715 remove delete_task from the Replica API so it's not misused 2020-11-29 14:26:47 -05:00
Dustin J. Mitchell
af7363f3aa add delete subcommand 2020-11-29 14:07:16 -05:00
Dustin J. Mitchell
29ab993397 add done 2020-11-29 14:07:16 -05:00
Dustin J. Mitchell
42d988d601 fix clippy warnings 2020-11-29 14:05:51 -05:00
Dustin J. Mitchell
d832b0b859 fix merge error 2020-11-29 11:18:29 -05:00
Dustin J. Mitchell
47cd051bd7
Merge pull request #71 from djmitche/issue7
Add start and stop commands
2020-11-28 23:19:21 -05:00
Dustin J. Mitchell
0e4ab4b88f Add start and stop commands 2020-11-28 23:12:37 -05:00