GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-27 00:57:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Replace direct Task.data access with a temp getter (syntactic refactor)

Browse source 
Now this getter, `data_removeme`, can easily be grepped out and
replaced, one usage at a time in small PRs.
This commit is contained in:
Dustin J. Mitchell 2021-11-18 02:08:16 +00:00 • committed by Tomas Babej
parent 3a00956144
commit dede40bc4e
10 changed files with 29 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/TDB2.cpp
View file

@ -1048,11 +1048,11 @@ void TDB2::show_diff (
Task before (prior);
std::vector <std::string> beforeAtts;
for (auto& att : before.data)
for (auto& att : before.data_removeme ())
beforeAtts.push_back (att.first);
std::vector <std::string> afterAtts;
for (auto& att : after.data)
for (auto& att : after.data_removeme ())
afterAtts.push_back (att.first);
std::vector <std::string> beforeOnly;
@ -1067,7 +1067,7 @@ void TDB2::show_diff (
view.set (row, 1, renderAttribute (name, before.get (name)), color_red);
}
for (auto& att : before.data)
for (auto& att : before.data_removeme ())
{
std::string priorValue = before.get (att.first);
std::string currentValue = after.get (att.first);
@ -1093,7 +1093,7 @@ void TDB2::show_diff (
else
{
int row;
for (auto& att : after.data)
for (auto& att : after.data_removeme ())
{
row = view.addRow ();
view.set (row, 0, att.first);
@ -1151,11 +1151,11 @@ void TDB2::show_diff (
std::vector <std::string> all = Context::getContext ().getColumns ();
// Now factor in the annotation attributes.
for (auto& it : before.data)
for (auto& it : before.data_removeme ())
if (it.first.substr (0, 11) == "annotation_")
all.push_back (it.first);
for (auto& it : after.data)
for (auto& it : after.data_removeme ())
if (it.first.substr (0, 11) == "annotation_")
all.push_back (it.first);