kdheepak/taskwarrior-tui
1
0
Fork 0
mirror of https://github.com/kdheepak/taskwarrior-tui.git synced 2025-08-23 11:07:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: Make duplication check more testable

Browse source
This commit is contained in:
RedEtherbloom 2024-06-11 19:06:59 +02:00
parent 38dcda31e3
commit f9660bb256
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/keyconfig.rs
View file

@ -1,7 +1,7 @@
use std::{collections::HashSet, error::Error, hash::Hash};
use anyhow::{anyhow, Result};
use log::{error, info, warn};
use log::{debug, error, info, warn};
use serde::{Deserialize, Serialize};
use crate::event::KeyCode;
@ -159,11 +159,12 @@ impl KeyConfig {
update_key(&mut self.shortcut8, "shortcut8");
update_key(&mut self.shortcut9, "shortcut9");
self.check()
let keys_to_check = self.keycodes_for_duplicate_check();
self.check_duplicates(keys_to_check)
}
pub fn check(&self) -> Result<()> {
let mut elements = vec![
fn keycodes_for_duplicate_check(&self) -> Vec<&KeyCode> {
vec![
&self.quit,
&self.refresh,
&self.go_to_bottom,
@ -192,7 +193,10 @@ impl KeyConfig {
&self.context_menu,
&self.next_tab,
&self.previous_tab,
];
]
}
pub fn check_duplicates(&self, mut elements: Vec<&KeyCode>) -> Result<()> {
let l = elements.len();
// TODO: Write Ord implementation for KeyCode.
// Vecs need to be sorted for dedup to work correctly.