From c3e27590284457739226c3b5cfdabc236323bdc1 Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Sat, 25 Feb 2017 14:17:25 -0500 Subject: [PATCH] TI-48: Timewarrior hook is not Python3 compatible - Thanks to Josh Proehl, Armado Martinez. --- AUTHORS | 1 + ChangeLog | 2 ++ ext/on-modify.timewarrior | 6 +++--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/AUTHORS b/AUTHORS index 9bfd0994..7e2e4717 100644 --- a/AUTHORS +++ b/AUTHORS @@ -21,6 +21,7 @@ The following submitted code, packages or analysis, and deserve special thanks: Felix Wolfsteller Jörg Krause Richard Brown + Armado Martinez Thanks to the following, who submitted detailed bug reports and excellent suggestions: diff --git a/ChangeLog b/ChangeLog index ef58e21a..a662e9d1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,8 @@ (thanks to Michael Meier) - TI-47 first call successfully creates new database but returns exit status 1 (thanks to Georg Sauthoff). +- TI-48 Timewarrior hook is not Python3 compatible + (thanks to Josh Proehl, Armado Martinez) - TI-49 new theme files aren't installed (thanks to Richard Brown). - TI-51 in the taskwarrior hook, deleting a task doesn't stop the watch diff --git a/ext/on-modify.timewarrior b/ext/on-modify.timewarrior index 08a640fb..b1da204b 100755 --- a/ext/on-modify.timewarrior +++ b/ext/on-modify.timewarrior @@ -57,16 +57,16 @@ combined = ' '.join(['"%s"' % tag for tag in tags]).encode('utf-8').strip() # Started task. if 'start' in new and not 'start' in old: - os.system('timew start ' + combined + ' :yes') + os.system('timew start ' + combined.decode() + ' :yes') # Stopped task. elif not 'start' in new and 'start' in old: - os.system('timew stop ' + combined + ' :yes') + os.system('timew stop ' + combined.decode() + ' :yes') # TI-51 - in the taskwarrior hook, deleting a task doesn't stop the watch # # Broadened to: Any task that is active, with a non-pending status should not # be tracked. elif 'start' in new and new['status'] != 'pending': - os.system('timew stop ' + combined + ' :yes') + os.system('timew stop ' + combined.decode() + ' :yes')