GothenburgBitFactory/timewarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/timewarrior.git synced 2025-07-07 20:06:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

getIntervalsById: Only add truly synthetic intervals to synthetic vector

Browse source 
This fixes an error where the latest interval, a non-synthetic interval,
is added to the synthetic array (and marked synthetic) if flatten() is
otherwise not able to convert it to a group of synthetic intervals.

When modify was attempting to edit this interval, it would fail since
synthetic intervals should not be written to the database unless the
database is being flattened and timewarrior believed the interval to be
modified was synthetic.

Closes #422

Signed-off-by: Shaun Ruffell <sruffell@sruffell.net>
This commit is contained in:
Shaun Ruffell 2021-05-13 08:28:09 -05:00 • committed by Thomas Lauf
parent 3e5aa0d7ec
commit bba56cc633
2 changed files with 50 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

29
test/modify.t
View file

@ -249,6 +249,35 @@ class TestModify(TestCase):
expectedTags=[],
description="moved interval")
def test_modify_move_start_inside_exclusion(self):
"""`timew modify` should handle moving start times within an exclusion."""
now = datetime.now().replace(second=0, microsecond=0, minute=0)
three_hours_before = now - timedelta(hours=3)
four_hours_before = now - timedelta(hours=4)
now_utc = now.utcnow().replace(second=0, microsecond=0, minute=0)
day_before = now_utc - timedelta(days=1)
three_hours_before_utc = now_utc - timedelta(hours=3)
four_hours_before_utc = now_utc - timedelta(hours=4)
five_hours_before_utc = now_utc - timedelta(hours=5)
self.t.configure_exclusions((four_hours_before.time(), three_hours_before.time()))
# Start an interval within the exclusion
self.t("start {:%Y-%m-%dT%H:%M:%S} foo".format(four_hours_before + timedelta(minutes=20)))
# Now modify the start time, but keep the start within the exclusion
self.t("modify start @1 {:%Y-%m-%dT%H:%M:%S} :debug".format(four_hours_before + timedelta(minutes=10)))
j = self.t.export()
self.assertEqual(len(j), 1)
self.assertOpenInterval(j[0],
expectedStart=four_hours_before_utc + timedelta(minutes=10),
expectedTags=['foo'])
if __name__ == "__main__":
from simpletap import TAPTestRunner