GothenburgBitFactory/timewarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/timewarrior.git synced 2025-07-07 20:06:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

#157: Change error message for non-positive IDs

Browse source
This commit is contained in:
Janik Rabe 2018-08-07 15:31:01 +03:00 • committed by lauft
parent 48aa9cfdc0
commit 616ca4b884
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/CLI.cpp
View file

@ -412,9 +412,11 @@ void CLI::identifyIds ()
int digits; int digits;
if (pig.skipLiteral ("@") && if (pig.skipLiteral ("@") &&
pig.getDigits (digits) && pig.getDigits (digits) &&
pig.eos () && pig.eos ())
digits > 0)
{ {
if (digits <= 0)
throw format ("'@{1}' is not a valid ID.", digits);
a.tag ("ID"); a.tag ("ID");
a.attribute ("value", digits); a.attribute ("value", digits);
} }

2
test/ids.t
View file

@ -50,7 +50,7 @@ class TestIds(TestCase):
def test_should_fail_on_zero_id(self): def test_should_fail_on_zero_id(self):
code, out, err = self.t.runError("delete @0") code, out, err = self.t.runError("delete @0")
self.assertIn("IDs must be specified.", err) self.assertIn("'@0' is not a valid ID.", err)
if __name__ == "__main__": if __name__ == "__main__":