Common: Modified split to be more pure function

src/common/text.cpp

@@ -29,6 +29,24 @@
 #include <iomanip>
 #include <math.h>
 
+////////////////////////////////////////////////////////////////////////////////
+std::vector <std::string> split (const std::string& input, const char delimiter)
+{
+  std::vector <std::string> results;
+  std::string::size_type start = 0;
+  std::string::size_type i;
+  while ((i = input.find (delimiter, start)) != std::string::npos)
+  {
+    results.push_back (input.substr (start, i - start));
+    start = i + 1;
+  }
+
+  if (input.length ())
+    results.push_back (input.substr (start));
+
+  return results;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 void split (
   std::vector<std::string>& results,

src/common/text.h

@@ -32,6 +32,7 @@
 #include <vector>
 
 // text.cpp, Non-UTF-8 aware.
+std::vector <std::string> split (const std::string&, const char);
 void split (std::vector<std::string>&, const std::string&, const char);
 const std::string format (std::string&);
 const std::string format (const char*);