AtomicFile: Make the forward impl declaration private

This is more consistent with the intent of the code.

Signed-off-by: Shaun Ruffell <sruffell@sruffell.net>
This commit is contained in:
Shaun Ruffell 2021-07-06 21:50:17 -05:00 committed by Thomas Lauf
parent 51d90114aa
commit 12696bf40c
2 changed files with 4 additions and 9 deletions

View file

@ -82,10 +82,7 @@ struct AtomicFile::impl
static atomic_files_t atomic_files;
};
using atomic_files_t = AtomicFile::impl::atomic_files_t;
using atomics_iterator = atomic_files_t::iterator;
atomic_files_t AtomicFile::impl::atomic_files {};
AtomicFile::impl::atomic_files_t AtomicFile::impl::atomic_files {};
bool AtomicFile::impl::allow_atomics {true};
////////////////////////////////////////////////////////////////////////////////
@ -283,7 +280,7 @@ void AtomicFile::impl::finalize ()
}
////////////////////////////////////////////////////////////////////////////////
atomics_iterator AtomicFile::impl::find (const Path& path)
AtomicFile::impl::iterator AtomicFile::impl::find (const Path& path)
{
auto end = impl::atomic_files.end ();
auto cmp = [&path](const atomic_files_t::value_type& p)
@ -483,7 +480,7 @@ void AtomicFile::finalize_all ()
sigprocmask (SIG_SETMASK, &old_mask, nullptr);
// Step 3: Cleanup any references
atomic_files_t new_atomic_files;
impl::atomic_files_t new_atomic_files;
for (auto& file : impl::atomic_files)
{
// Delete entry if we are holding the last reference

View file

@ -70,10 +70,8 @@ public:
static void finalize_all ();
static void reset ();
public:
struct impl;
private:
struct impl;
std::shared_ptr <impl> pimpl;
};