GothenburgBitFactory/timewarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/timewarrior.git synced 2025-07-07 20:06:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make python tests use timezone, py3.12 deprecated tz-less utcnow()

Browse source 
Python upstream is trying to eliminate tz-naive date functions that
imply anything to do with a timezone, even UTC.  They have deprecated
datetime.datetime.utcnow() in Python 3.12 and thus running tests emits
many warnings for us.

We switch to instantiate datetime objects taht are intended to reflect
UTC to have a timezone, or if we instantiate naive ones and then later
convert, we do the full conversion.

After the changes, the tests still work on Python 3.9, but now also on
Python 3.12 without warnings.

See PR description for #632 for more details.

Signed-off-by: Scott Mcdermott <scott@smemsh.net>
This commit is contained in:
Scott Mcdermott 2024-08-20 19:06:13 -07:00 • committed by Thomas Lauf
parent 05b72bba6f
commit 05724a9d21
22 changed files with 220 additions and 207 deletions
Download patch file Download diff file Expand all files Collapse all files

14
test/track.t
View file

@ -30,7 +30,7 @@ import os
import sys
import unittest
from datetime import datetime, timedelta, time
from datetime import datetime, timezone, timedelta, time
# Ensure python finds the local simpletap module
sys.path.append(os.path.dirname(os.path.abspath(__file__)))
@ -101,7 +101,7 @@ class TestTrack(TestCase):
def test_track_with_new_tag(self):
"""Call 'track' with new tag"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
two_hours_before_utc = now_utc - timedelta(hours=2)
one_hour_before_utc = now_utc - timedelta(hours=1)
@ -114,7 +114,7 @@ class TestTrack(TestCase):
def test_track_with_previous_tag(self):
"""Call 'track' with previous tag"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
two_hours_before_utc = now_utc - timedelta(hours=2)
one_hour_before_utc = now_utc - timedelta(hours=1)
@ -127,7 +127,7 @@ class TestTrack(TestCase):
def test_track_with_future_time(self):
"""Test track with future interval is not an error"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
two_hours_after_utc = now_utc + timedelta(hours=2)
one_hour_after_utc = now_utc + timedelta(hours=1)
@ -145,7 +145,7 @@ class TestTrack(TestCase):
def test_track_with_adjust_should_overwrite_enclosed_interval_with_same_start(self):
"""Command track with adjust should overwrite enclosed interval with same start"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
four_hours_before = now_utc - timedelta(hours=4)
three_hours_before = now_utc - timedelta(hours=3)
@ -164,7 +164,7 @@ class TestTrack(TestCase):
def test_track_with_adjust_should_overwrite_enclosed_interval_with_same_end(self):
"""Command track with adjust should overwrite enclosed interval with same end"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
five_hours_before = now_utc - timedelta(hours=5)
four_hours_before = now_utc - timedelta(hours=4)
@ -183,7 +183,7 @@ class TestTrack(TestCase):
def test_track_with_adjust_should_overwrite_identical_interval(self):
"""Command track with adjust should overwrite identical interval"""
now_utc = datetime.now().utcnow()
now_utc = datetime.now(timezone.utc)
four_hours_before = now_utc - timedelta(hours=4)
three_hours_before = now_utc - timedelta(hours=3)