mirror of
https://github.com/GothenburgBitFactory/taskwarrior.git
synced 2025-06-26 10:54:26 +02:00
b33a99a748
With this patch, taskwarrior uses the urgency of tasks before any modifications are applied when deciding whether to show nag messages. Previously, taskwarrior would apply modifications before deciding whether to show nag messages, which could lead to spurious nag messages when completing an active task.
141 lines
4.6 KiB
C++
141 lines
4.6 KiB
C++
////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright 2006 - 2021, Paul Beckingham, Federico Hernandez.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
//
|
|
// https://www.opensource.org/licenses/mit-license.php
|
|
//
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include <cmake.h>
|
|
#include <CmdStart.h>
|
|
#include <iostream>
|
|
#include <Context.h>
|
|
#include <Filter.h>
|
|
#include <main.h>
|
|
#include <format.h>
|
|
#include <util.h>
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
CmdStart::CmdStart ()
|
|
{
|
|
_keyword = "start";
|
|
_usage = "task <filter> start <mods>";
|
|
_description = "Marks specified task as started";
|
|
_read_only = false;
|
|
_displays_id = false;
|
|
_needs_gc = false;
|
|
_uses_context = true;
|
|
_accepts_filter = true;
|
|
_accepts_modifications = true;
|
|
_accepts_miscellaneous = false;
|
|
_category = Command::Category::operation;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
int CmdStart::execute (std::string&)
|
|
{
|
|
int rc = 0;
|
|
int count = 0;
|
|
|
|
// Apply filter.
|
|
Filter filter;
|
|
std::vector <Task> filtered;
|
|
filter.subset (filtered);
|
|
if (filtered.size () == 0)
|
|
{
|
|
Context::getContext ().footnote ("No tasks specified.");
|
|
return 1;
|
|
}
|
|
|
|
// Accumulated project change notifications.
|
|
std::map <std::string, std::string> projectChanges;
|
|
|
|
if(filtered.size() > 1) {
|
|
feedback_affected("This command will alter {1} tasks.", filtered.size());
|
|
}
|
|
|
|
std::vector <Task> modified;
|
|
for (auto& task : filtered)
|
|
{
|
|
if (! task.has ("start"))
|
|
{
|
|
Task before (task);
|
|
|
|
// Start the specified task.
|
|
std::string question = format ("Start task {1} '{2}'?",
|
|
task.identifier (true),
|
|
task.get ("description"));
|
|
task.modify (Task::modAnnotate);
|
|
task.setAsNow ("start");
|
|
|
|
Task::status status = task.getStatus ();
|
|
if (status == Task::completed || status == Task::deleted)
|
|
{
|
|
// "waiting" handled by Task::validate(), no special care needed here.
|
|
task.setStatus (Task::pending);
|
|
}
|
|
|
|
if (Context::getContext ().config.getBoolean ("journal.time"))
|
|
task.addAnnotation (Context::getContext ().config.get ("journal.time.start.annotation"));
|
|
|
|
if (permission (taskDifferences (before, task) + question, filtered.size ()))
|
|
{
|
|
updateRecurrenceMask (task);
|
|
Context::getContext ().tdb2.modify (task);
|
|
++count;
|
|
feedback_affected ("Starting task {1} '{2}'.", task);
|
|
dependencyChainOnStart (task);
|
|
if (Context::getContext ().verbose ("project"))
|
|
projectChanges[task.get ("project")] = onProjectChange (task, false);
|
|
|
|
// Save unmodified task for potential nagging later
|
|
modified.push_back(before);
|
|
}
|
|
else
|
|
{
|
|
std::cout << "Task not started.\n";
|
|
rc = 1;
|
|
if (_permission_quit)
|
|
break;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
std::cout << format ("Task {1} '{2}' already started.",
|
|
task.id,
|
|
task.get ("description"))
|
|
<< '\n';
|
|
rc = 1;
|
|
}
|
|
}
|
|
|
|
nag (modified);
|
|
|
|
// Now list the project changes.
|
|
for (auto& change : projectChanges)
|
|
if (change.first != "")
|
|
Context::getContext ().footnote (change.second);
|
|
|
|
feedback_affected (count == 1 ? "Started {1} task." : "Started {1} tasks.", count);
|
|
return rc;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|