Having self.diag and self.t.diag was confusing as one referred to TAP
output (self.diag) while the other referred to "task diagnostics"
self.t.diag.
self.diag is now gone and was replaced by self.tap with the same
behavior.
- More robust tests strategy: captured outputs are always compared to some
expected result.
- Clearer and more consistent test.
Signed-off-by: Paul Beckingham <paul@beckingham.net>
- Removed the feature that allows commands to be piped in to stdin,
and appended to any existing command line. This feature is
conditionally compiled, controlled by the FEATURE_STDIN define in
main.h
- Many unit tests contained "echo '-- y'", and now use "echo 'y'"
because the '--' is no longer supported on stdin.
- Thanks to the IRC team for testing, including Bryce Harrington,
Sam Stuck, Owen Clarke, Greg Grossmeier.
- Now that the 'diagnostics' command can detect duplicate UUID
values, it makes sense to incorporate that into unit tests that
employ multiple recurring tasks.
- While fixing bug.360.t, discovered a bigger problem, which is not yet
fixed. When a due date is removed from a recurring child task, the
imask, parent and recur attributes should also be removed. Similarly
when a recur frequency is removed from a recurring child task, the
imask and parent should also be removed.
- Net result: two new failing tests.
- Many tests referred to 'synch_key.data', which is not the correct
name. It should be 'synch.key'. This has no effect on the number
of passing tests though.
- Corrected all unit tests that used the old syntax "task done 1" to
use the new syntax "task 1 done". Similarly, "task 1 ..." is now
"task 1 modify ...".
