- Modified the ::getBlockingTasks and ::getBlockedTasks to match the code that
performs the dependency scan. While this doesn't change functionality, it
does align the logic.
- Many files were missing an explicit cmake.h include. Some were not including
it at all. Now it's used almost everywhere.
(cherry picked from commit 82ae86979c497e6d1d0c6b2b5a55aa379ec82c98)
- Fixed bug #1022, where dependencies were note released when a blocking task
was completed (thanks to Arkady Grudzinsky).
- The Task object now caches ::is_blocked and ::is_blocking Booleans that are
determined on pending.data load.
- Simplified and sped up color rule processing using cached values, reducing
the number of map lookups, and removed loop invariants when the rules are
not defined.
- Simplified urgency calculations given the cached values for blocked/blocking.
- On load, pending.data is scanned for accurate blocked/blocking status
determination.
- Obsoleted and removed complex single-task dependency calculations.
- Sped up 'nag' processing by using cached values..
- Modified the 'show' command to consider color.blocking to be valid.
- Added default config value for color.blocking, and included it in the
precedence list ahead of blocked, as it is more important.
- Updated taskrc.5 man page to include the new color.blocking rule, and its
place in the rule precedence.
- The problem was that the routine dependencyIsCircular() changed its behaviour
in git revision 726fc33fe4, and the new version
only checked tasks by id - but all completed/deleted tasks have the id0, which
led to the problem. The fix is extremelly simple, just get the dependencies
by uuid instead of by id.
Signed-off-by: Paul Beckingham <paul@beckingham.net>
- Removed the last uses of 'foreach'. What remains is only code that
is being obsoleted, and therefore there is no need to clean that up.
- The definition of 'foreach' in util.h must remain until last.
