GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

recur: Prevent infinite loops with 0 periods

Browse source 
Specifying a recurrence interval that amounts to a zero, like 'P0M', 0q
or 0m causes task to fall into an infinite loop when trying to determine
next recurrence dates.

Detect scenarios with zero-length recurrence interval and throw an
exception.

Closes #2262.
This commit is contained in:
Tomas Babej 2020-12-06 20:49:35 -05:00
parent ccb222a31b
commit fcfe01f301
No known key found for this signature in database
GPG key ID: B0747C6578F7D2F5
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/recur.cpp
View file

@ -234,6 +234,9 @@ Datetime getNextRecurrence (Datetime& current, std::string& period)
{
int increment = strtol (period.substr (0, period.length () - 1).c_str (), nullptr, 10);
if (increment <= 0)
throw format ("Recurrence period '{1}' is equivalent to {2} and hence invalid.", period, increment);
m += increment;
while (m > 12)
{
@ -253,6 +256,9 @@ Datetime getNextRecurrence (Datetime& current, std::string& period)
{
int increment = strtol (period.substr (1, period.length () - 2).c_str (), nullptr, 10);
if (increment <= 0)
throw format ("Recurrence period '{1}' is equivalent to {2} and hence invalid.", period, increment);
m += increment;
while (m > 12)
{
@ -286,6 +292,9 @@ Datetime getNextRecurrence (Datetime& current, std::string& period)
{
int increment = strtol (period.substr (0, period.length () - 1).c_str (), nullptr, 10);
if (increment <= 0)
throw format ("Recurrence period '{1}' is equivalent to {2} and hence invalid.", period, increment);
m += 3 * increment;
while (m > 12)
{