Unit Tests

- Removed useless setup/teardown tests, improving the signal to noise ratio.
This commit is contained in:
Paul Beckingham 2014-06-01 10:24:43 -04:00
parent ca06927eea
commit fbdceac548
3 changed files with 7 additions and 39 deletions

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 13; use Test::More tests => 9;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'import.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"dateformat=m/d/Y\n"; "dateformat=m/d/Y\n";
close $fh; close $fh;
ok (-r 'import.rc', 'Created import.rc');
} }
# Create import file. # Create import file.
@ -50,9 +49,7 @@ if (open my $fh, '>', 'import.txt')
{"uuid":"11111111-1111-1111-1111-111111111111","description":"one","project":"B","status":"pending","entry":"1234567889"}, {"uuid":"11111111-1111-1111-1111-111111111111","description":"one","project":"B","status":"pending","entry":"1234567889"},
{"uuid":"22222222-2222-2222-2222-222222222222","description":"two","status":"completed","entry":"1234524689","end":"1234524690"} {"uuid":"22222222-2222-2222-2222-222222222222","description":"two","status":"completed","entry":"1234524689","end":"1234524690"}
EOF EOF
close $fh; close $fh;
ok (-r 'import.txt', 'Created sample import data');
} }
my $output = qx{../src/task rc:import.rc import import.txt 2>&1 >/dev/null}; my $output = qx{../src/task rc:import.rc import import.txt 2>&1 >/dev/null};
@ -92,9 +89,7 @@ if (open my $fh, '>', 'import2.txt')
print $fh <<EOF; print $fh <<EOF;
{"uuid":"44444444-4444-4444-4444-444444444444","description":"three","status":"pending","entry":"1234567889"} {"uuid":"44444444-4444-4444-4444-444444444444","description":"three","status":"pending","entry":"1234567889"}
EOF EOF
close $fh; close $fh;
ok (-r 'import2.txt', 'Created second sample import data');
} }
$output = qx{../src/task rc:import.rc import import2.txt 2>&1 >/dev/null}; $output = qx{../src/task rc:import.rc import import2.txt 2>&1 >/dev/null};
@ -103,13 +98,5 @@ like ($output, qr/Imported 1 tasks\./, 'no errors');
# Cleanup. # Cleanup.
unlink qw(import.txt import2.txt pending.data completed.data undo.data backlog.data import.rc); unlink qw(import.txt import2.txt pending.data completed.data undo.data backlog.data import.rc);
ok (! -r 'import.txt' &&
! -r 'import2.txt' &&
! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'import.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 26; use Test::More tests => 23;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -44,7 +44,6 @@ if (open my $fh, '>', 'import.rc')
"dateformat=YYYY-M-D\n", "dateformat=YYYY-M-D\n",
"verbose=off\n"; "verbose=off\n";
close $fh; close $fh;
ok (-r 'import.rc', 'Created import.rc');
} }
# Create import file. # Create import file.
@ -66,7 +65,6 @@ if (open my $fh, '>', 'import.txt')
"x 2011-03-02 2011-03-01 Review Tim's pull request +TodoTxtTouch \@github\n"; # - "x 2011-03-02 2011-03-01 Review Tim's pull request +TodoTxtTouch \@github\n"; # -
close $fh; close $fh;
ok (-r 'import.txt', 'Created sample import data');
} }
# Convert todo.sh --> task JSON. # Convert todo.sh --> task JSON.
@ -127,13 +125,5 @@ like ($output, qr/^Description.+xylophone lesson/ms, '12 <desc>');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data import.rc import.txt import.json); unlink qw(pending.data completed.data undo.data backlog.data import.rc import.txt import.json);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'import.rc' &&
! -r 'import.txt' &&
! -r 'import.json', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 16; use Test::More tests => 13;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -42,7 +42,6 @@ if (open my $fh, '>', 'import.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"dateformat=m/d/Y\n"; "dateformat=m/d/Y\n";
close $fh; close $fh;
ok (-r 'import.rc', 'Created import.rc');
} }
# Create import file. # Create import file.
@ -73,7 +72,6 @@ if (open my $fh, '>', 'import.txt')
EOF EOF
close $fh; close $fh;
ok (-r 'import.txt', 'Created sample import data');
} }
# Convert YAML --> task JSON. # Convert YAML --> task JSON.
@ -148,12 +146,5 @@ like ($output, qr/3.+three/, 't3 present');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data import.rc import.txt import.json); unlink qw(pending.data completed.data undo.data backlog.data import.rc import.txt import.json);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'import.rc' &&
! -r 'import.txt' &&
! -r 'import.json', 'Cleanup');
exit 0; exit 0;