mirror of
https://github.com/GothenburgBitFactory/taskwarrior.git
synced 2025-07-07 20:06:36 +02:00
Filter Bugs
- A substitution arg is categorized as "subst", but was tested for "substitution". - The Arguments::is_multipart method was triggering on '/', which is wrong, but I can't remember why I put it in there. Hmmm. - When extracting a write-filter, substitutions after the command were generating an error, whereas they should be ignored. - Task::substitute was modifying data even when the patterns were not matching. Yikes. - Added unit tests for en-passant modification of all types during done, delete, start, stop.
This commit is contained in:
Paul Beckingham
parent
69e70889be
commit
f0d2af2651
7 changed files with 369 additions and 22 deletions
83
test/args.2.t
Executable file
83
test/args.2.t
Executable file
|
|
@ -0,0 +1,83 @@
|
|||
#! /usr/bin/perl
|
||||
################################################################################
|
||||
## taskwarrior - a command line task list manager.
|
||||
##
|
||||
## Copyright 2006 - 2011, Paul Beckingham, Federico Hernandez.
|
||||
## All rights reserved.
|
||||
##
|
||||
## This program is free software; you can redistribute it and/or modify it under
|
||||
## the terms of the GNU General Public License as published by the Free Software
|
||||
## Foundation; either version 2 of the License, or (at your option) any later
|
||||
## version.
|
||||
##
|
||||
## This program is distributed in the hope that it will be useful, but WITHOUT
|
||||
## ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
||||
## FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
||||
## details.
|
||||
##
|
||||
## You should have received a copy of the GNU General Public License along with
|
||||
## this program; if not, write to the
|
||||
##
|
||||
## Free Software Foundation, Inc.,
|
||||
## 51 Franklin Street, Fifth Floor,
|
||||
## Boston, MA
|
||||
## 02110-1301
|
||||
## USA
|
||||
##
|
||||
################################################################################
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use Test::More tests => 10;
|
||||
|
||||
# Create the rc file.
|
||||
if (open my $fh, '>', 'args.rc')
|
||||
{
|
||||
print $fh "data.location=.\n",
|
||||
"confirmation=off\n";
|
||||
close $fh;
|
||||
ok (-r 'args.rc', 'Created args.rc');
|
||||
}
|
||||
|
||||
# Test 'done' with en-passant changes.
|
||||
qx{../src/task rc:args.rc add one};
|
||||
qx{../src/task rc:args.rc add two};
|
||||
qx{../src/task rc:args.rc add three};
|
||||
qx{../src/task rc:args.rc add four};
|
||||
qx{../src/task rc:args.rc add five};
|
||||
|
||||
qx{../src/task rc:args.rc 1 done oneanno};
|
||||
my $output = qx{../src/task rc:args.rc 1 info};
|
||||
like ($output, qr/oneanno/, 'done enpassant anno');
|
||||
|
||||
qx{../src/task rc:args.rc 2 done /two/TWO/};
|
||||
$output = qx{../src/task rc:args.rc 2 info};
|
||||
like ($output, qr/Description\s+TWO/, 'done enpassant subst');
|
||||
|
||||
qx{../src/task rc:args.rc 3 done +threetag};
|
||||
$output = qx{../src/task rc:args.rc 3 info};
|
||||
like ($output, qr/Tags\s+threetag/, 'done enpassant tag');
|
||||
|
||||
qx{../src/task rc:args.rc 4 done pri:H};
|
||||
$output = qx{../src/task rc:args.rc 4 info};
|
||||
like ($output, qr/Priority\s+H/, 'done enpassant priority');
|
||||
|
||||
qx{../src/task rc:args.rc 5 done pro:A};
|
||||
$output = qx{../src/task rc:args.rc 5 info};
|
||||
like ($output, qr/Project\s+A/, 'done enpassant project');
|
||||
|
||||
# Cleanup.
|
||||
unlink 'pending.data';
|
||||
ok (!-r 'pending.data', 'Removed pending.data');
|
||||
|
||||
unlink 'completed.data';
|
||||
ok (!-r 'completed.data', 'Removed completed.data');
|
||||
|
||||
unlink 'undo.data';
|
||||
ok (!-r 'undo.data', 'Removed undo.data');
|
||||
|
||||
unlink 'args.rc';
|
||||
ok (!-r 'args.rc', 'Removed args.rc');
|
||||
|
||||
exit 0;
|
||||
|
||||
83
test/args.3.t
Executable file
83
test/args.3.t
Executable file
|
|
@ -0,0 +1,83 @@
|
|||
#! /usr/bin/perl
|
||||
################################################################################
|
||||
## taskwarrior - a command line task list manager.
|
||||
##
|
||||
## Copyright 2006 - 2011, Paul Beckingham, Federico Hernandez.
|
||||
## All rights reserved.
|
||||
##
|
||||
## This program is free software; you can redistribute it and/or modify it under
|
||||
## the terms of the GNU General Public License as published by the Free Software
|
||||
## Foundation; either version 2 of the License, or (at your option) any later
|
||||
## version.
|
||||
##
|
||||
## This program is distributed in the hope that it will be useful, but WITHOUT
|
||||
## ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
||||
## FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
||||
## details.
|
||||
##
|
||||
## You should have received a copy of the GNU General Public License along with
|
||||
## this program; if not, write to the
|
||||
##
|
||||
## Free Software Foundation, Inc.,
|
||||
## 51 Franklin Street, Fifth Floor,
|
||||
## Boston, MA
|
||||
## 02110-1301
|
||||
## USA
|
||||
##
|
||||
################################################################################
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use Test::More tests => 10;
|
||||
|
||||
# Create the rc file.
|
||||
if (open my $fh, '>', 'args.rc')
|
||||
{
|
||||
print $fh "data.location=.\n",
|
||||
"confirmation=off\n";
|
||||
close $fh;
|
||||
ok (-r 'args.rc', 'Created args.rc');
|
||||
}
|
||||
|
||||
# Test 'delete' with en-passant changes.
|
||||
qx{../src/task rc:args.rc add one};
|
||||
qx{../src/task rc:args.rc add two};
|
||||
qx{../src/task rc:args.rc add three};
|
||||
qx{../src/task rc:args.rc add four};
|
||||
qx{../src/task rc:args.rc add five};
|
||||
|
||||
qx{../src/task rc:args.rc 1 delete oneanno};
|
||||
my $output = qx{../src/task rc:args.rc 1 info};
|
||||
like ($output, qr/oneanno/, 'delete enpassant anno');
|
||||
|
||||
qx{../src/task rc:args.rc 2 delete /two/TWO/};
|
||||
$output = qx{../src/task rc:args.rc 2 info};
|
||||
like ($output, qr/Description\s+TWO/, 'delete enpassant subst');
|
||||
|
||||
qx{../src/task rc:args.rc 3 delete +threetag};
|
||||
$output = qx{../src/task rc:args.rc 3 info};
|
||||
like ($output, qr/Tags\s+threetag/, 'delete enpassant tag');
|
||||
|
||||
qx{../src/task rc:args.rc 4 delete pri:H};
|
||||
$output = qx{../src/task rc:args.rc 4 info};
|
||||
like ($output, qr/Priority\s+H/, 'delete enpassant priority');
|
||||
|
||||
qx{../src/task rc:args.rc 5 delete pro:A};
|
||||
$output = qx{../src/task rc:args.rc 5 info};
|
||||
like ($output, qr/Project\s+A/, 'delete enpassant project');
|
||||
|
||||
# Cleanup.
|
||||
unlink 'pending.data';
|
||||
ok (!-r 'pending.data', 'Removed pending.data');
|
||||
|
||||
unlink 'completed.data';
|
||||
ok (!-r 'completed.data', 'Removed completed.data');
|
||||
|
||||
unlink 'undo.data';
|
||||
ok (!-r 'undo.data', 'Removed undo.data');
|
||||
|
||||
unlink 'args.rc';
|
||||
ok (!-r 'args.rc', 'Removed args.rc');
|
||||
|
||||
exit 0;
|
||||
|
||||
83
test/args.4.t
Executable file
83
test/args.4.t
Executable file
|
|
@ -0,0 +1,83 @@
|
|||
#! /usr/bin/perl
|
||||
################################################################################
|
||||
## taskwarrior - a command line task list manager.
|
||||
##
|
||||
## Copyright 2006 - 2011, Paul Beckingham, Federico Hernandez.
|
||||
## All rights reserved.
|
||||
##
|
||||
## This program is free software; you can redistribute it and/or modify it under
|
||||
## the terms of the GNU General Public License as published by the Free Software
|
||||
## Foundation; either version 2 of the License, or (at your option) any later
|
||||
## version.
|
||||
##
|
||||
## This program is distributed in the hope that it will be useful, but WITHOUT
|
||||
## ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
||||
## FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
||||
## details.
|
||||
##
|
||||
## You should have received a copy of the GNU General Public License along with
|
||||
## this program; if not, write to the
|
||||
##
|
||||
## Free Software Foundation, Inc.,
|
||||
## 51 Franklin Street, Fifth Floor,
|
||||
## Boston, MA
|
||||
## 02110-1301
|
||||
## USA
|
||||
##
|
||||
################################################################################
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use Test::More tests => 10;
|
||||
|
||||
# Create the rc file.
|
||||
if (open my $fh, '>', 'args.rc')
|
||||
{
|
||||
print $fh "data.location=.\n",
|
||||
"confirmation=off\n";
|
||||
close $fh;
|
||||
ok (-r 'args.rc', 'Created args.rc');
|
||||
}
|
||||
|
||||
# Test 'start' with en-passant changes.
|
||||
qx{../src/task rc:args.rc add one};
|
||||
qx{../src/task rc:args.rc add two};
|
||||
qx{../src/task rc:args.rc add three};
|
||||
qx{../src/task rc:args.rc add four};
|
||||
qx{../src/task rc:args.rc add five};
|
||||
|
||||
qx{../src/task rc:args.rc 1 start oneanno};
|
||||
my $output = qx{../src/task rc:args.rc 1 info};
|
||||
like ($output, qr/oneanno/, 'start enpassant anno');
|
||||
|
||||
qx{../src/task rc:args.rc 2 start /two/TWO/};
|
||||
$output = qx{../src/task rc:args.rc 2 info};
|
||||
like ($output, qr/Description\s+TWO/, 'start enpassant subst');
|
||||
|
||||
qx{../src/task rc:args.rc 3 start +threetag};
|
||||
$output = qx{../src/task rc:args.rc 3 info};
|
||||
like ($output, qr/Tags\s+threetag/, 'start enpassant tag');
|
||||
|
||||
qx{../src/task rc:args.rc 4 start pri:H};
|
||||
$output = qx{../src/task rc:args.rc 4 info};
|
||||
like ($output, qr/Priority\s+H/, 'start enpassant priority');
|
||||
|
||||
qx{../src/task rc:args.rc 5 start pro:A};
|
||||
$output = qx{../src/task rc:args.rc 5 info};
|
||||
like ($output, qr/Project\s+A/, 'start enpassant project');
|
||||
|
||||
# Cleanup.
|
||||
unlink 'pending.data';
|
||||
ok (!-r 'pending.data', 'Removed pending.data');
|
||||
|
||||
unlink 'completed.data';
|
||||
ok (!-r 'completed.data', 'Removed completed.data');
|
||||
|
||||
unlink 'undo.data';
|
||||
ok (!-r 'undo.data', 'Removed undo.data');
|
||||
|
||||
unlink 'args.rc';
|
||||
ok (!-r 'args.rc', 'Removed args.rc');
|
||||
|
||||
exit 0;
|
||||
|
||||
83
test/args.5.t
Executable file
83
test/args.5.t
Executable file
|
|
@ -0,0 +1,83 @@
|
|||
#! /usr/bin/perl
|
||||
################################################################################
|
||||
## taskwarrior - a command line task list manager.
|
||||
##
|
||||
## Copyright 2006 - 2011, Paul Beckingham, Federico Hernandez.
|
||||
## All rights reserved.
|
||||
##
|
||||
## This program is free software; you can redistribute it and/or modify it under
|
||||
## the terms of the GNU General Public License as published by the Free Software
|
||||
## Foundation; either version 2 of the License, or (at your option) any later
|
||||
## version.
|
||||
##
|
||||
## This program is distributed in the hope that it will be useful, but WITHOUT
|
||||
## ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
||||
## FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
||||
## details.
|
||||
##
|
||||
## You should have received a copy of the GNU General Public License along with
|
||||
## this program; if not, write to the
|
||||
##
|
||||
## Free Software Foundation, Inc.,
|
||||
## 51 Franklin Street, Fifth Floor,
|
||||
## Boston, MA
|
||||
## 02110-1301
|
||||
## USA
|
||||
##
|
||||
################################################################################
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use Test::More tests => 10;
|
||||
|
||||
# Create the rc file.
|
||||
if (open my $fh, '>', 'args.rc')
|
||||
{
|
||||
print $fh "data.location=.\n",
|
||||
"confirmation=off\n";
|
||||
close $fh;
|
||||
ok (-r 'args.rc', 'Created args.rc');
|
||||
}
|
||||
|
||||
# Test 'stop' with en-passant changes.
|
||||
qx{../src/task rc:args.rc add one};
|
||||
qx{../src/task rc:args.rc add two};
|
||||
qx{../src/task rc:args.rc add three};
|
||||
qx{../src/task rc:args.rc add four};
|
||||
qx{../src/task rc:args.rc add five};
|
||||
|
||||
qx{../src/task rc:args.rc 1 stop oneanno};
|
||||
my $output = qx{../src/task rc:args.rc 1 info};
|
||||
like ($output, qr/oneanno/, 'stop enpassant anno');
|
||||
|
||||
qx{../src/task rc:args.rc 2 stop /two/TWO/};
|
||||
$output = qx{../src/task rc:args.rc 2 info};
|
||||
like ($output, qr/Description\s+TWO/, 'stop enpassant subst');
|
||||
|
||||
qx{../src/task rc:args.rc 3 stop +threetag};
|
||||
$output = qx{../src/task rc:args.rc 3 info};
|
||||
like ($output, qr/Tags\s+threetag/, 'stop enpassant tag');
|
||||
|
||||
qx{../src/task rc:args.rc 4 stop pri:H};
|
||||
$output = qx{../src/task rc:args.rc 4 info};
|
||||
like ($output, qr/Priority\s+H/, 'stop enpassant priority');
|
||||
|
||||
qx{../src/task rc:args.rc 5 stop pro:A};
|
||||
$output = qx{../src/task rc:args.rc 5 info};
|
||||
like ($output, qr/Project\s+A/, 'stop enpassant project');
|
||||
|
||||
# Cleanup.
|
||||
unlink 'pending.data';
|
||||
ok (!-r 'pending.data', 'Removed pending.data');
|
||||
|
||||
unlink 'completed.data';
|
||||
ok (!-r 'completed.data', 'Removed completed.data');
|
||||
|
||||
unlink 'undo.data';
|
||||
ok (!-r 'undo.data', 'Removed undo.data');
|
||||
|
||||
unlink 'args.rc';
|
||||
ok (!-r 'args.rc', 'Removed args.rc');
|
||||
|
||||
exit 0;
|
||||
|
||||
Loading…
Add table
Add a link
Reference in a new issue