From eaffa392f9582fd8d94c01de23c33ad16bd9e7d9 Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Sun, 1 Jun 2014 10:00:45 -0400 Subject: [PATCH] Unit Tests - Removed useless setup/teardown tests, improving the signal to noise ratio. --- test/date.iso.t | 11 ++--------- test/dateformat.t | 13 +------------ test/denotate.t | 9 +-------- test/oldest.t | 9 +-------- test/overdue.t | 9 +-------- test/override.t | 9 +-------- test/prepend.t | 9 +-------- test/project.t | 9 +-------- 8 files changed, 9 insertions(+), 69 deletions(-) diff --git a/test/date.iso.t b/test/date.iso.t index a6ac1de9f..20b62fb93 100755 --- a/test/date.iso.t +++ b/test/date.iso.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 4; +use Test::More tests => 2; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -39,7 +39,6 @@ if (open my $fh, '>', 'iso.rc') print $fh "data.location=.\n", "dateformat.info=m/d/Y\n"; close $fh; - ok (-r 'iso.rc', 'Created iso.rc'); } # Test use of ISO date format, despite rc.dateformat. @@ -48,17 +47,11 @@ my $output = qx{../src/task rc:iso.rc 1 info 2>&1}; like ($output, qr/Due\s+9\/1\/2011/, 'ISO format recognized.'); # Test use of epoch date format, despite rc.dateformat. -qx{../src/task rc:iso.rc add one due:1234524690 2>&1}; +qx{../src/task rc:iso.rc add two due:1234524690 2>&1}; $output = qx{../src/task rc:iso.rc 2 info 2>&1}; like ($output, qr/Due\s+2\/13\/2009/, 'Epoch format recognized.'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data iso.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'iso.rc', 'Cleanup'); - exit 0; diff --git a/test/dateformat.t b/test/dateformat.t index 6773c9632..9745a4ef7 100755 --- a/test/dateformat.t +++ b/test/dateformat.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 10; +use Test::More tests => 6; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -41,7 +41,6 @@ if (open my $fh, '>', 'date1.rc') "dateformat.info=YMD\n", "dateformat.report=YMD\n"; close $fh; - ok (-r 'date1.rc', 'Created date1.rc'); } if (open my $fh, '>', 'date2.rc') @@ -51,7 +50,6 @@ if (open my $fh, '>', 'date2.rc') "dateformat.info=m/d/y\n", "dateformat.report=m/d/y\n"; close $fh; - ok (-r 'date2.rc', 'Created date2.rc'); } if (open my $fh, '>', 'date3.rc') @@ -63,7 +61,6 @@ if (open my $fh, '>', 'date3.rc') "dateformat.info=A D B Y (wV)\n", "dateformat.report=A D B Y (wV)\n"; close $fh; - ok (-r 'date3.rc', 'Created date3.rc'); } qx{../src/task rc:date1.rc add foo due:20091231 2>&1}; @@ -88,13 +85,5 @@ like ($output, qr/08 Apr 2010 - Thu/, 'date format D b Y - a parsed'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data date1.rc date2.rc date3.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'date1.rc' && - ! -r 'date2.rc' && - ! -r 'date3.rc', 'Cleanup'); - exit 0; diff --git a/test/denotate.t b/test/denotate.t index 57c7c3684..26dfbe3ac 100755 --- a/test/denotate.t +++ b/test/denotate.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 27; +use Test::More tests => 25; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -45,7 +45,6 @@ if (open my $fh, '>', 'denotate.rc') "report.rrr.sort=id+\n", "dateformat=m/d/Y\n"; close $fh; - ok (-r 'denotate.rc', 'Created denotate.rc'); } # Add four tasks, annotate one three times, one twice, one just once and one none. @@ -105,10 +104,4 @@ unlike ($output, qr/frog.+\d{1,2}\/\d{1,2}\/\d{4} Kermit and Miss Piggy/ms, 'Del # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data denotate.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'denotate.rc', 'Cleanup'); - exit 0; diff --git a/test/oldest.t b/test/oldest.t index a9b776771..35b043f36 100755 --- a/test/oldest.t +++ b/test/oldest.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 54; +use Test::More tests => 52; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -38,7 +38,6 @@ if (open my $fh, '>', 'oldest.rc') { print $fh "data.location=.\n"; close $fh; - ok (-r 'oldest.rc', 'Created oldest.rc'); } # Add 11 tasks. Oldest should show 1-10, newest should show 2-11. @@ -132,11 +131,5 @@ like ($output, qr/ eleven/, 'newest: eleven'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data oldest.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'oldest.rc', 'Cleanup'); - exit 0; diff --git a/test/overdue.t b/test/overdue.t index 36601b08c..c0bcc08f0 100755 --- a/test/overdue.t +++ b/test/overdue.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 5; +use Test::More tests => 3; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -39,7 +39,6 @@ if (open my $fh, '>', 'due.rc') print $fh "data.location=.\n", "due=4\n"; close $fh; - ok (-r 'due.rc', 'Created due.rc'); } # Add an overdue task, a due task, and a regular task. The "overdue" report @@ -54,11 +53,5 @@ unlike ($output, qr/three/, 'overdue: task 3 does not show up'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data due.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'due.rc', 'Cleanup'); - exit 0; diff --git a/test/override.t b/test/override.t index dcb172904..790dba2c2 100755 --- a/test/override.t +++ b/test/override.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 3; +use Test::More tests => 1; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -43,7 +43,6 @@ if (open my $fh, '>', 'or.rc') "report.zzz.sort=due+\n", "report.zzz.filter=status:pending rc.annotations:full\n"; close $fh; - ok (-r 'or.rc', 'Created or.rc'); } # The zzz report is defined with an override in the filter that contradicts @@ -55,11 +54,5 @@ like ($output, qr/ONE.+TWO/ms, 'filter override > rc setting'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data or.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'or.rc', 'Cleanup'); - exit 0; diff --git a/test/prepend.t b/test/prepend.t index 84db5237e..b7a0c66c2 100755 --- a/test/prepend.t +++ b/test/prepend.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 4; +use Test::More tests => 2; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -38,7 +38,6 @@ if (open my $fh, '>', 'prepend.rc') { print $fh "data.location=.\n"; close $fh; - ok (-r 'prepend.rc', 'Created prepend.rc'); } # Add a task, then prepend more decsription. @@ -53,11 +52,5 @@ unlike ($output, qr/Prepended 0 tasks/, 'blank prepend failed'); # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data prepend.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'prepend.rc', 'Cleanup'); - exit 0; diff --git a/test/project.t b/test/project.t index cb75d21ab..c29e7810d 100755 --- a/test/project.t +++ b/test/project.t @@ -27,7 +27,7 @@ use strict; use warnings; -use Test::More tests => 18; +use Test::More tests => 16; # Ensure environment has no influence. delete $ENV{'TASKDATA'}; @@ -39,7 +39,6 @@ if (open my $fh, '>', 'pro.rc') print $fh "data.location=.\n", "confirmation=off\n"; close $fh; - ok (-r 'pro.rc', 'Created pro.rc'); } # Test the project status numbers. @@ -156,11 +155,5 @@ like ($project_name_column, qr/^myProject\.\s*$/, '\'myProject.\' not indented') # Cleanup. unlink qw(pending.data completed.data undo.data backlog.data pro.rc); -ok (! -r 'pending.data' && - ! -r 'completed.data' && - ! -r 'undo.data' && - ! -r 'backlog.data' && - ! -r 'pro.rc', 'Cleanup'); - exit 0;