GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-09-06 17:37:21 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

performance: Avoid lexing input when not needed in getDOM

Browse source 
Lexing a token can be expensive operation. Perform lexing only if a
UUID/ID reference could have been provided.
This commit is contained in:
Tomas Babej 2021-04-23 22:42:41 -04:00
parent c3f9d09d22
commit e7487c8a63
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/DOM.cpp
View file

@ -265,7 +265,10 @@ bool getDOM (const std::string& name, const Task& task, Variant& value)
Lexer lexer (elements[0]);
std::string token;
Lexer::Type type;
if (lexer.token (token, type))
// If this can be ID/UUID reference (the name contains '.'),
// lex it to figure out. Otherwise don't lex, as lexing can be slow.
if ((elements.size() > 1) and lexer.token (token, type))
{
if (type == Lexer::Type::uuid &&
token.length () == elements[0].length ())