GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Bug #835

Browse source 
- Fixed bug #835, which prevented hierarchical projects from being recognized.
This commit is contained in:
Paul Beckingham 2011-09-21 00:19:42 -04:00
parent 965e15fe91
commit e478f6626b
4 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
ChangeLog
View file

@ -186,6 +186,7 @@
+ Fixed bug #808, which generated compiler warnings on Solarix (thanks to + Fixed bug #808, which generated compiler warnings on Solarix (thanks to
Owen Clarke). Owen Clarke).
+ Fixed bug #831, which prevented some date fields from being properly parsed. + Fixed bug #831, which prevented some date fields from being properly parsed.
+ Fixed bug #835, which prevented hierarchical projects from being recognized.
# Untracked Bugs, biggest first. # Untracked Bugs, biggest first.
+ Fixed bug that required the '%YAML' prologue in a YAML import. + Fixed bug that required the '%YAML' prologue in a YAML import.

3
src/A3.cpp
View file

@ -1256,8 +1256,7 @@ bool A3::is_attr (Nibbler& n, Arg& arg)
// Consider removing this for a stricter parse. // Consider removing this for a stricter parse.
if (n.getQuoted ('"', value) || if (n.getQuoted ('"', value) ||
n.getQuoted ('\'', value) || n.getQuoted ('\'', value) ||
n.getName (value) || n.getUntilOneOf (" \t)(", value) ||
n.getUntilWS (value) ||
n.getUntilEOS (value) || n.getUntilEOS (value) ||
n.depleted ()) n.depleted ())
{ {

1
src/commands/Command.cpp
View file

@ -431,7 +431,6 @@ void Command::modify_task (
// Get the column info. // Get the column info.
Column* column = context.columns[name]; Column* column = context.columns[name];
if (value == "") if (value == "")
{ {
task.remove (name); task.remove (name);

6
test/bug.835.t
View file

@ -28,7 +28,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 3; use Test::More tests => 5;
# Create the rc file. # Create the rc file.
if (open my $fh, '>', 'bug.rc') if (open my $fh, '>', 'bug.rc')
@ -42,6 +42,10 @@ qx{../src/task rc:bug.rc add pro:main.subproject Test};
my $output = qx{../src/task rc:bug.rc ls}; my $output = qx{../src/task rc:bug.rc ls};
like ($output, qr/main\.subproject/, "hierarchical project ok"); like ($output, qr/main\.subproject/, "hierarchical project ok");
qx{../src/task rc:bug.rc \\(pro:main.subproject\\) ls};
like ($output, qr/main\.subproject/, "Parens tolerated");
unlike ($output, qr/Mismatched parentheses in expression/, "No 'mismatch' error generated");
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data synch.key bug.rc); unlink qw(pending.data completed.data undo.data backlog.data synch.key bug.rc);
ok (! -r 'pending.data' && ok (! -r 'pending.data' &&