mirror of
https://github.com/GothenburgBitFactory/taskwarrior.git
synced 2025-08-20 22:33:08 +02:00
Bug, Reorg
- Fixed bug in journal annotations that omitted \n characters for certain events, creating an unreadable journal entry. - Relocated the 'Total active time' into the journal table, made the text bold, and changed from "Xh XXm" format to Duration::format.
This commit is contained in:
parent
200fbe3334
commit
e301cda990
2 changed files with 25 additions and 29 deletions
|
@ -675,10 +675,6 @@ int handleInfo (std::string& outs)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
out << optionalBlankLine ()
|
|
||||||
<< table.render ()
|
|
||||||
<< "\n";
|
|
||||||
|
|
||||||
journal.setTableWidth (context.getWidth ());
|
journal.setTableWidth (context.getWidth ());
|
||||||
journal.setDateFormat (context.config.get ("dateformat"));
|
journal.setDateFormat (context.config.get ("dateformat"));
|
||||||
|
|
||||||
|
@ -708,7 +704,7 @@ int handleInfo (std::string& outs)
|
||||||
std::string previous;
|
std::string previous;
|
||||||
std::string current;
|
std::string current;
|
||||||
unsigned int i = 0;
|
unsigned int i = 0;
|
||||||
long time = 0;
|
long total_time = 0;
|
||||||
while (i < undo.size ())
|
while (i < undo.size ())
|
||||||
{
|
{
|
||||||
when = undo[i++];
|
when = undo[i++];
|
||||||
|
@ -737,41 +733,41 @@ int handleInfo (std::string& outs)
|
||||||
&& after.get ("start") != "")
|
&& after.get ("start") != "")
|
||||||
{
|
{
|
||||||
// task started
|
// task started
|
||||||
time -= timestamp.toEpoch();
|
total_time -= timestamp.toEpoch ();
|
||||||
}
|
}
|
||||||
else if (before.get ("start") != ""
|
else if (before.get ("start") != ""
|
||||||
&& after.get ("start") == "")
|
&& after.get ("start") == "")
|
||||||
{
|
{
|
||||||
// task stopped
|
// task stopped
|
||||||
time += timestamp.toEpoch();
|
total_time += timestamp.toEpoch ();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// add now() if task is still active
|
||||||
|
if (total_time < 0)
|
||||||
|
total_time += Date ().toEpoch ();
|
||||||
|
|
||||||
|
|
||||||
|
// print total active time
|
||||||
|
if (total_time > 0)
|
||||||
|
{
|
||||||
|
row = journal.addRow ();
|
||||||
|
journal.addCell (row, 0, "Total active time");
|
||||||
|
journal.addCell (row, 1, Duration (total_time).format ());
|
||||||
|
|
||||||
|
if (context.config.getBoolean ("color") || context.config.getBoolean ("_forcecolor"))
|
||||||
|
journal.setCellColor (row, 1, Color ("bold"));
|
||||||
|
}
|
||||||
|
|
||||||
|
out << optionalBlankLine ()
|
||||||
|
<< table.render ()
|
||||||
|
<< "\n";
|
||||||
|
|
||||||
if (journal.rowCount () > 0)
|
if (journal.rowCount () > 0)
|
||||||
out << journal.render ()
|
out << journal.render ()
|
||||||
<< "\n";
|
<< "\n";
|
||||||
|
|
||||||
// add now() if task is still active
|
|
||||||
if (time < 0)
|
|
||||||
time += Date().toEpoch();
|
|
||||||
|
|
||||||
// print total active time
|
|
||||||
if (time >= 0)
|
|
||||||
{
|
|
||||||
int row = journal.addRow ();
|
|
||||||
int hours = time / 3600;
|
|
||||||
int minutes = (time % 3600) / 60;
|
|
||||||
|
|
||||||
out << "Total active time: "
|
|
||||||
<< hours << "h " << minutes;
|
|
||||||
|
|
||||||
if (minutes == 0)
|
|
||||||
out << "0";
|
|
||||||
|
|
||||||
out << "m\n\n";
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -506,7 +506,7 @@ std::string taskInfoDifferences (const Task& before, const Task& after)
|
||||||
{
|
{
|
||||||
out << "annotation added '"
|
out << "annotation added '"
|
||||||
<< after.get (*name)
|
<< after.get (*name)
|
||||||
<< "'";
|
<< "'\n";
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
out << *name
|
out << *name
|
||||||
|
@ -542,7 +542,7 @@ std::string taskInfoDifferences (const Task& before, const Task& after)
|
||||||
{
|
{
|
||||||
out << "annotation '"
|
out << "annotation '"
|
||||||
<< after.get (*name)
|
<< after.get (*name)
|
||||||
<< "'";
|
<< "'\n";
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
out << *name
|
out << *name
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue