GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-27 10:07:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[BREAKING] Remove journal.info support

Browse source 
This support will require access to all of the operations ever performed
on a task, which is not currently exposed by TaskChampion (but see #2928)
This commit is contained in:
Dustin J. Mitchell 2022-12-15 02:52:43 +00:00 • committed by Dustin J. Mitchell
parent cf711f5eb1
commit ddd367232e
6 changed files with 4 additions and 152 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/TDB2.h
View file

@ -156,7 +156,6 @@ protected:
friend class CmdSync; // CmdSync accesses the backlog directly
TF2 backlog;
friend class CmdInfo; // CmdInfo uses undo data to give history
TF2 undo;
private:

57
src/commands/CmdInfo.cpp
View file

@ -77,11 +77,6 @@ int CmdInfo::execute (std::string& output)
rc = 1;
}
// Get the undo data.
std::vector <std::string> undo;
if (Context::getContext ().config.getBoolean ("journal.info"))
undo = Context::getContext ().tdb2.undo.get_lines ();
// Determine the output date format, which uses a hierarchy of definitions.
// rc.dateformat.info
// rc.dateformat
@ -530,54 +525,6 @@ int CmdInfo::execute (std::string& output)
urgencyDetails.set (row, 5, rightJustify (format (task.urgency (), 4, 4), 6));
}
// Create a third table, containing undo log change details.
Table journal;
setHeaderUnderline (journal);
if (Context::getContext ().config.getBoolean ("obfuscate"))
journal.obfuscate ();
if (Context::getContext ().config.getBoolean ("color"))
journal.forceColor ();
journal.width (Context::getContext ().getWidth ());
journal.add ("Date");
journal.add ("Modification");
if (Context::getContext ().config.getBoolean ("journal.info") &&
undo.size () > 3)
{
// Scan the undo data for entries matching this task, without making
// copies.
unsigned int i = 0;
long last_timestamp = 0;
while (i < undo.size ())
{
int when = i++;
int previous = -1;
if (! undo[i].compare (0, 3, "old", 3))
previous = i++;
int current = i++;
i++; // Separator
if (undo[current].find ("uuid:\"" + uuid) != std::string::npos)
{
if (previous != -1)
{
int row = journal.addRow ();
Datetime timestamp (strtol (undo[when].substr (5).c_str (), nullptr, 10));
journal.set (row, 0, timestamp.toString (dateformat));
Task before (undo[previous].substr (4));
Task after (undo[current].substr (4));
journal.set (row, 1, before.diffForInfo (after, dateformat, last_timestamp, Datetime(after.get("modified")).toEpoch()));
}
}
}
}
out << optionalBlankLine ()
<< view.render ()
<< '\n';
@ -585,10 +532,6 @@ int CmdInfo::execute (std::string& output)
if (urgencyDetails.rows () > 0)
out << urgencyDetails.render ()
<< '\n';
if (journal.rows () > 0)
out << journal.render ()
<< '\n';
}
output = out.str ();