From 471571e493ef050b0de635456305f845c2d268d3 Mon Sep 17 00:00:00 2001 From: Cory Donnelly Date: Sun, 1 Aug 2010 09:56:41 -0400 Subject: [PATCH 1/3] Unit Tests - UTF-8 characters in reports - Added bug.455.t for Bug #455 - Text alignment in reports is broken when text contains utf8 characters --- src/tests/bug.455.t | 65 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100755 src/tests/bug.455.t diff --git a/src/tests/bug.455.t b/src/tests/bug.455.t new file mode 100755 index 000000000..1ad93f210 --- /dev/null +++ b/src/tests/bug.455.t @@ -0,0 +1,65 @@ +#! /usr/bin/perl +################################################################################ +## task - a command line task list manager. +## +## Copyright 2006 - 2010, Paul Beckingham. +## All rights reserved. +## +## This program is free software; you can redistribute it and/or modify it under +## the terms of the GNU General Public License as published by the Free Software +## Foundation; either version 2 of the License, or (at your option) any later +## version. +## +## This program is distributed in the hope that it will be useful, but WITHOUT +## ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS +## FOR A PARTICULAR PURPOSE. See the GNU General Public License for more +## details. +## +## You should have received a copy of the GNU General Public License along with +## this program; if not, write to the +## +## Free Software Foundation, Inc., +## 51 Franklin Street, Fifth Floor, +## Boston, MA +## 02110-1301 +## USA +## +################################################################################ + +use strict; +use warnings; +use Test::More tests => 7; + +# Create the rc file. +if (open my $fh, '>', '455.rc') +{ + print $fh "data.location=.\n"; + + close $fh; + ok (-r '455.rc', 'Created 455.rc'); +} + +# Bug #455 - Text alignment in reports is broken when text contains utf8 characters + +qx{../task rc:455.rc add abc pro:Bar\x{263A}}; +qx{../task rc:455.rc add def pro:Foo!}; + +my $output = qx{../task rc:455.rc ls}; + +like ($output, qr/\s{7}abc/ms, 'bug 455 - correct spacing in utf8 task'); +like ($output, qr/\s{7}def/ms, 'bug 455 - correct spacing in non utf8 task'); + +# Cleanup. +unlink 'pending.data'; +ok (!-r 'pending.data', 'Removed pending.data'); + +unlink 'completed.data'; +ok (!-r 'completed.data', 'Removed completed.data'); + +unlink 'undo.data'; +ok (!-r 'undo.data', 'Removed undo.data'); + +unlink '455.rc'; +ok (!-r '455.rc', 'Removed 455.rc'); + +exit 0; From 44e7a24170e79608bb9a7184eee58f72168b6e97 Mon Sep 17 00:00:00 2001 From: Cory Donnelly Date: Sun, 1 Aug 2010 10:05:16 -0400 Subject: [PATCH 2/3] Documentation - Added Mac OS X Tiger to NEWS --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 07f7fec4c..f07f1557e 100644 --- a/NEWS +++ b/NEWS @@ -39,7 +39,7 @@ Newly deprecated features in task 1.9.3 Task has been built and tested on the following configurations: - * OS X 10.6 Snow Leopard and 10.5 Leopard + * OS X 10.6 Snow Leopard, 10.5 Leopard, and 10.4 Tiger * Fedora 13 Goddard, 12 Constantine * Ubuntu 10.04 Lucid Lynx, 9.10 Karmic Koala * Debian Sid From cddc2d5f10b0a669bb241fcbfda1fdbc244a582f Mon Sep 17 00:00:00 2001 From: Cory Donnelly Date: Sun, 1 Aug 2010 10:11:11 -0400 Subject: [PATCH 3/3] Revert "Documentation" This reverts commit 44e7a24170e79608bb9a7184eee58f72168b6e97. I just saw that Fredde intentionally removed X-2 versions from the OS list in NEWS. --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f07f1557e..07f7fec4c 100644 --- a/NEWS +++ b/NEWS @@ -39,7 +39,7 @@ Newly deprecated features in task 1.9.3 Task has been built and tested on the following configurations: - * OS X 10.6 Snow Leopard, 10.5 Leopard, and 10.4 Tiger + * OS X 10.6 Snow Leopard and 10.5 Leopard * Fedora 13 Goddard, 12 Constantine * Ubuntu 10.04 Lucid Lynx, 9.10 Karmic Koala * Debian Sid