mirror of
https://github.com/GothenburgBitFactory/taskwarrior.git
synced 2025-08-28 13:37:20 +02:00
Bug
- Fixed bug that caused entry, end, start and wait dates to not use report- specific date format overrides (thanks to Eric Fluger).
This commit is contained in:
parent
47f2758c8f
commit
d4772fe060
3 changed files with 31 additions and 5 deletions
2
AUTHORS
2
AUTHORS
|
@ -38,6 +38,7 @@ The following submitted code, packages or analysis, and deserve special thanks:
|
||||||
Sander Marechal
|
Sander Marechal
|
||||||
Stephen Heywood
|
Stephen Heywood
|
||||||
Nicola Busanello
|
Nicola Busanello
|
||||||
|
Eric Fluger
|
||||||
|
|
||||||
Thanks to the following, who submitted detailed bug reports and excellent
|
Thanks to the following, who submitted detailed bug reports and excellent
|
||||||
suggestions:
|
suggestions:
|
||||||
|
@ -72,7 +73,6 @@ suggestions:
|
||||||
Max Muller
|
Max Muller
|
||||||
Thomas Sattler
|
Thomas Sattler
|
||||||
Erlan Sergaziev
|
Erlan Sergaziev
|
||||||
Eric Fluger
|
|
||||||
Steve Rader
|
Steve Rader
|
||||||
Andy Kriger
|
Andy Kriger
|
||||||
|
|
||||||
|
|
|
@ -39,6 +39,8 @@
|
||||||
+ The dependency columns are now right-justified (thanks to Eric Fluger).
|
+ The dependency columns are now right-justified (thanks to Eric Fluger).
|
||||||
+ Fixed bug that caused the 'done' command to always exit with a non-zero
|
+ Fixed bug that caused the 'done' command to always exit with a non-zero
|
||||||
status (thanks to Steve Rader).
|
status (thanks to Steve Rader).
|
||||||
|
+ Fixed bug that caused entry, end, start and wait dates to not use report-
|
||||||
|
specific date format overrides (thanks to Eric Fluger).
|
||||||
+ Fixed bug #515, which displayed an incorrect message after duplicating a
|
+ Fixed bug #515, which displayed an incorrect message after duplicating a
|
||||||
non-existent task (thanks to Peter De Poorter).
|
non-existent task (thanks to Peter De Poorter).
|
||||||
+ Fixed bug #529, where the 'depends' attribute was not mentioned in the
|
+ Fixed bug #529, where the 'depends' attribute was not mentioned in the
|
||||||
|
|
|
@ -228,6 +228,12 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
table.setColumnWidth (columnCount, Table::minimum);
|
table.setColumnWidth (columnCount, Table::minimum);
|
||||||
table.setColumnJustification (columnCount, Table::right);
|
table.setColumnJustification (columnCount, Table::right);
|
||||||
|
|
||||||
|
std::string format = context.config.get ("report." + report + ".dateformat");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat.report");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat");
|
||||||
|
|
||||||
std::string entered;
|
std::string entered;
|
||||||
for (unsigned int row = 0; row < tasks.size(); ++row)
|
for (unsigned int row = 0; row < tasks.size(); ++row)
|
||||||
{
|
{
|
||||||
|
@ -235,7 +241,7 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
if (entered.length ())
|
if (entered.length ())
|
||||||
{
|
{
|
||||||
Date dt (::atoi (entered.c_str ()));
|
Date dt (::atoi (entered.c_str ()));
|
||||||
entered = dt.toString (context.config.get ("dateformat"));
|
entered = dt.toString (format);
|
||||||
context.hooks.trigger ("format-entry", "entry", entered);
|
context.hooks.trigger ("format-entry", "entry", entered);
|
||||||
table.addCell (row, columnCount, entered);
|
table.addCell (row, columnCount, entered);
|
||||||
}
|
}
|
||||||
|
@ -248,6 +254,12 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
table.setColumnWidth (columnCount, Table::minimum);
|
table.setColumnWidth (columnCount, Table::minimum);
|
||||||
table.setColumnJustification (columnCount, Table::right);
|
table.setColumnJustification (columnCount, Table::right);
|
||||||
|
|
||||||
|
std::string format = context.config.get ("report." + report + ".dateformat");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat.report");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat");
|
||||||
|
|
||||||
std::string started;
|
std::string started;
|
||||||
for (unsigned int row = 0; row < tasks.size(); ++row)
|
for (unsigned int row = 0; row < tasks.size(); ++row)
|
||||||
{
|
{
|
||||||
|
@ -255,7 +267,7 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
if (started.length ())
|
if (started.length ())
|
||||||
{
|
{
|
||||||
Date dt (::atoi (started.c_str ()));
|
Date dt (::atoi (started.c_str ()));
|
||||||
started = dt.toString (context.config.get ("dateformat"));
|
started = dt.toString (format);
|
||||||
context.hooks.trigger ("format-start", "start", started);
|
context.hooks.trigger ("format-start", "start", started);
|
||||||
table.addCell (row, columnCount, started);
|
table.addCell (row, columnCount, started);
|
||||||
}
|
}
|
||||||
|
@ -268,6 +280,12 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
table.setColumnWidth (columnCount, Table::minimum);
|
table.setColumnWidth (columnCount, Table::minimum);
|
||||||
table.setColumnJustification (columnCount, Table::right);
|
table.setColumnJustification (columnCount, Table::right);
|
||||||
|
|
||||||
|
std::string format = context.config.get ("report." + report + ".dateformat");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat.report");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat");
|
||||||
|
|
||||||
std::string ended;
|
std::string ended;
|
||||||
for (unsigned int row = 0; row < tasks.size(); ++row)
|
for (unsigned int row = 0; row < tasks.size(); ++row)
|
||||||
{
|
{
|
||||||
|
@ -275,7 +293,7 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
if (ended.length ())
|
if (ended.length ())
|
||||||
{
|
{
|
||||||
Date dt (::atoi (ended.c_str ()));
|
Date dt (::atoi (ended.c_str ()));
|
||||||
ended = dt.toString (context.config.get ("dateformat"));
|
ended = dt.toString (format);
|
||||||
context.hooks.trigger ("format-end", "end", ended);
|
context.hooks.trigger ("format-end", "end", ended);
|
||||||
table.addCell (row, columnCount, ended);
|
table.addCell (row, columnCount, ended);
|
||||||
}
|
}
|
||||||
|
@ -500,6 +518,12 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
table.setColumnWidth (columnCount, Table::minimum);
|
table.setColumnWidth (columnCount, Table::minimum);
|
||||||
table.setColumnJustification (columnCount, Table::right);
|
table.setColumnJustification (columnCount, Table::right);
|
||||||
|
|
||||||
|
std::string format = context.config.get ("report." + report + ".dateformat");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat.report");
|
||||||
|
if (format == "")
|
||||||
|
format = context.config.get ("dateformat");
|
||||||
|
|
||||||
int row = 0;
|
int row = 0;
|
||||||
std::string wait;
|
std::string wait;
|
||||||
foreach (task, tasks)
|
foreach (task, tasks)
|
||||||
|
@ -508,7 +532,7 @@ int handleCustomReport (const std::string& report, std::string& outs)
|
||||||
if (wait != "")
|
if (wait != "")
|
||||||
{
|
{
|
||||||
Date dt (::atoi (wait.c_str ()));
|
Date dt (::atoi (wait.c_str ()));
|
||||||
wait = dt.toString (context.config.get ("dateformat"));
|
wait = dt.toString (format);
|
||||||
context.hooks.trigger ("format-wait", "wait", wait);
|
context.hooks.trigger ("format-wait", "wait", wait);
|
||||||
table.addCell (row++, columnCount, wait);
|
table.addCell (row++, columnCount, wait);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue