GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-09-10 22:20:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Command: Code cleanup, added ::category accessor

Browse source 
- The Command object failed to initialize all member on construction and
  initialized them out of order (is this still a thing in C++11?).
- The _category was the only member with no accessor, which is not right.
This commit is contained in:
Paul Beckingham 2015-09-06 14:07:21 -04:00
parent 77b17379d6
commit d1fe1279ed
3 changed files with 32 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/commands/Command.h
View file

@ -35,23 +35,6 @@
class Command
{
public:
Command ();
virtual ~Command ();
static void factory (std::map <std::string, Command*>&);
std::string keyword () const;
std::string usage () const;
std::string description () const;
bool read_only () const;
bool displays_id () const;
bool needs_gc () const;
bool uses_context () const;
bool accepts_filter () const;
bool accepts_modifications () const;
bool accepts_miscellaneous () const;
virtual int execute (std::string&) = 0;
enum class Category
{
unassigned,
@ -68,7 +51,24 @@ public:
UNDOCUMENTED,
// Whenever you extend this enum, update categoryNames.
};
Category _category;
Command ();
virtual ~Command ();
static void factory (std::map <std::string, Command*>&);
std::string keyword () const;
std::string usage () const;
std::string description () const;
bool read_only () const;
bool displays_id () const;
bool needs_gc () const;
bool uses_context () const;
bool accepts_filter () const;
bool accepts_modifications () const;
bool accepts_miscellaneous () const;
Category category () const;
virtual int execute (std::string&) = 0;
protected:
bool permission (const Task&, const std::string&, unsigned int);
@ -86,6 +86,7 @@ protected:
bool _accepts_filter;
bool _accepts_modifications;
bool _accepts_miscellaneous;
Category _category;
// Permission support
bool _permission_quit;