GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Unit Tests

Browse source 
- While fixing bug.360.t, discovered a bigger problem, which is not yet
  fixed.  When a due date is removed from a recurring child task, the
  imask, parent and recur attributes should also be removed.  Similarly
  when a recur frequency is removed from a recurring child task, the
  imask and parent should also be removed.
- Net result: two new failing tests.
This commit is contained in:
Paul Beckingham 2011-09-12 22:57:32 -04:00
parent 02047a6e99
commit d1e52c05d6
3 changed files with 28 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

47
src/commands/CmdModify.cpp
View file

@ -78,37 +78,38 @@ int CmdModify::execute (std::string& output)
Task before (*task);
modify_task_description_replace (*task, modifications);
// Perform some logical consistency checks.
if (task->has ("recur") &&
!task->has ("due") &&
!before.has ("due"))
throw std::string ("You cannot specify a recurring task without a due date.");
if (task->has ("until") &&
!task->has ("recur") &&
!before.has ("recur"))
throw std::string ("You cannot specify an until date for a non-recurring task.");
if (before.has ("recur") &&
before.has ("due") &&
(!task->has ("due") ||
task->get ("due") == ""))
throw std::string ("You cannot remove the due date from a recurring task.");
if (before.has ("recur") &&
task->has ("recur") &&
(!task->has ("recur") ||
task->get ("recur") == ""))
throw std::string ("You cannot remove the recurrence from a recurring task.");
if (taskDiff (before, *task) &&
permission.confirmed (*task, taskDifferences (before, *task) + "Proceed with change?"))
{
// Checks passed, modify the task.
++count;
context.tdb2.modify (*task);
if (before.get ("project") != task->get ("project"))
context.footnote (onProjectChange (before, *task));
// Perform some logical consistency checks.
// TODO Shouldn't these tests be in Task::validate?
if (task->has ("recur") &&
!task->has ("due") &&
!before.has ("due"))
throw std::string ("You cannot specify a recurring task without a due date.");
if (task->has ("until") &&
!task->has ("recur") &&
!before.has ("recur"))
throw std::string ("You cannot specify an until date for a non-recurring task.");
if (before.has ("recur") &&
before.has ("due") &&
task->has ("due") &&
task->get ("due") == "")
throw std::string ("You cannot remove the due date from a recurring task.");
if (before.has ("recur") &&
task->has ("recur") &&
task->get ("recur") == "")
throw std::string ("You cannot remove the recurrence from a recurring task.");
// Make all changes.
bool warned = false;
std::vector <Task> siblings = context.tdb2.siblings (*task);