Fix and test handling of backslashes in hooks (#3909)

* Update hooks to use `read -r` and `printf`

This portably avoids any interpretation of backslash escapes by the
shell.

* Support running make_tc_task elsewhere

* Add a test for backslashes in task descriptions

test/test_hooks/on-add-accept

@@ -5,12 +5,12 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $new_task
+printf "%s\n" "$new_task"
 echo 'FEEDBACK'
 
 # Status:

test/test_hooks/on-add-misbehave2

@@ -5,7 +5,7 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-add-misbehave3

@@ -5,12 +5,12 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $new_task
+printf "%s\n" "$new_task"
 echo '{"description":"extra","status":"pending"}'
 echo 'FEEDBACK'
 

test/test_hooks/on-add-misbehave4

@@ -5,7 +5,7 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-add-misbehave5

@@ -5,7 +5,7 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-add-misbehave6

@@ -5,7 +5,7 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-add-modify

@@ -2,17 +2,17 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
-if (echo $new_task | grep -qE '[tT]eh');
+if (printf "%s\n" "$new_task" | grep -qE '[tT]eh');
 then
-  new_task=$(echo $new_task | sed -r 's/([tT])eh/\1he/g')
+  new_task=$(printf "%s\n" "$new_task" | sed -r 's/([tT])eh/\1he/g')
 fi
 
 # Output:
 # - JSON, modified
 # - Optional feedback/error.
-echo $new_task
+printf "%s\n" "$new_task"
 echo 'FEEDBACK'
 
 # Status:

test/test_hooks/on-add-reject

@@ -5,12 +5,12 @@
 
 # Input:
 # - Line of JSON for proposed new task.
-read new_task
+read -r new_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $new_task
+printf "%s\n" "$new_task"
 echo 'FEEDBACK'
 
 # Status:

test/test_hooks/on-add.dummy

@@ -2,9 +2,9 @@
 
 echo "on-add executed"
 
-while read TASK; do
+while read -r TASK; do
     echo "New task $TASK"
-    echo $TASK
+    printf "%s\n" "$TASK"
 done
 
 exit 0

test/test_hooks/on-exit-bad

@@ -5,7 +5,7 @@
 
 # Input:
 # - Read-only line of JSON for each task added/modified
-while read modified_task
+while read -r modified_task
 do
   echo 'CHANGED TASK'
 done

test/test_hooks/on-exit-good

@@ -5,7 +5,7 @@
 
 # Input:
 # - Read-only line of JSON for each task added/modified
-while read modified_task
+while read -r modified_task
 do
   echo 'CHANGED TASK'
 done

test/test_hooks/on-exit.dummy

@@ -2,7 +2,7 @@
 
 echo "on-exit executed"
 
-while read TASK; do
+while read -r TASK; do
     echo "New/modified task $TASK"
 done
 

test/test_hooks/on-modify-accept

@@ -6,13 +6,13 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $modified_task
+printf "%s\n" "$modified_task"
 echo 'FEEDBACK'
 
 # Status:

test/test_hooks/on-modify-misbehave2

@@ -6,8 +6,8 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-modify-misbehave3

@@ -6,13 +6,13 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $modified_task
+printf "%s\n" "$modified_task"
 echo '{"description":"extra","status":"pending"}'
 echo 'FEEDBACK'
 

test/test_hooks/on-modify-misbehave4

@@ -6,8 +6,8 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-modify-misbehave5

@@ -6,8 +6,8 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-modify-misbehave6

@@ -6,8 +6,8 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.

test/test_hooks/on-modify-reject

@@ -6,13 +6,13 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $modified_task
+printf "%s\n" "$modified_task"
 echo 'FEEDBACK'
 
 # Status:

test/test_hooks/on-modify-revert

@@ -6,13 +6,13 @@
 # Input:
 # - line of JSON for the original task
 # - line of JSON for the modified task, the diff being the modification
-read original_task
-read modified_task
+read -r original_task
+read -r modified_task
 
 # Output:
 # - JSON, modified or unmodified.
 # - Optional feedback/error.
-echo $original_task
+printf "%s\n" "$original_task"
 
 # Status:
 # - 0:     JSON accepted, non-JSON is feedback.

test/test_hooks/on-modify.dummy

@@ -2,9 +2,10 @@
 
 echo "on-modify executed"
 
-while read TASK MODTASK; do
-    echo "Existing task $TASK modified to $MODTASK"
-    echo $MODTASK
-done
+read -r TASK
+read -r MODTASK
+
+echo "Existing task $TASK modified to $MODTASK"
+printf "%s\n" "$MODTASK"
 
 exit 0