Revert "[clang-tidy] Use const reference instead of initializing string"

This reverts commit ab170e34df.
This commit is contained in:
Paul Beckingham 2020-12-05 16:18:15 -05:00
parent 7d8fff418e
commit c3ecfac4f5

View file

@ -242,7 +242,7 @@ static bool sort_compare (int left, int right)
// UDAs. // UDAs.
else if ((column = Context::getContext ().columns[field]) != nullptr) else if ((column = Context::getContext ().columns[field]) != nullptr)
{ {
const std::string& type = column->type (); std::string type = column->type ();
if (type == "numeric") if (type == "numeric")
{ {
auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr); auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr);