From c0f4baa8d94bc7664097135804a8f1e3dfe9b031 Mon Sep 17 00:00:00 2001
From: Paul Beckingham <paul@beckingham.net>
Date: Sun, 1 Jun 2014 09:44:18 -0400
Subject: [PATCH] Unit Tests

- Removed useless setup/teardown tests, improving the signal to noise ratio.
---
 test/args.1.t | 9 +--------
 test/args.2.t | 9 +--------
 test/args.3.t | 9 +--------
 test/args.4.t | 9 +--------
 test/args.5.t | 9 +--------
 test/args.t   | 9 +--------
 6 files changed, 6 insertions(+), 48 deletions(-)

diff --git a/test/args.1.t b/test/args.1.t
index c567b3632..5f3e171c6 100755
--- a/test/args.1.t
+++ b/test/args.1.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 8;
+use Test::More tests => 6;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=off\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test id before command, and id after command.
@@ -60,11 +59,5 @@ unlike ($output, qr/^Completed 1 task.$/ms, 'ID after COMMAND');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/args.2.t b/test/args.2.t
index f301b684f..fb35b4bd9 100755
--- a/test/args.2.t
+++ b/test/args.2.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 7;
+use Test::More tests => 5;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=off\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test 'done' with en-passant changes.
@@ -71,11 +70,5 @@ like ($output, qr/Project\s+A/, 'done enpassant project');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/args.3.t b/test/args.3.t
index 895a93819..725ce3786 100755
--- a/test/args.3.t
+++ b/test/args.3.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 7;
+use Test::More tests => 5;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=off\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test 'delete' with en-passant changes.
@@ -71,11 +70,5 @@ like ($output, qr/Project\s+A/, 'delete enpassant project');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/args.4.t b/test/args.4.t
index 6d371ceec..001437f16 100755
--- a/test/args.4.t
+++ b/test/args.4.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 7;
+use Test::More tests => 5;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=off\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test 'start' with en-passant changes.
@@ -71,11 +70,5 @@ like ($output, qr/Project\s+A/, 'start enpassant project');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/args.5.t b/test/args.5.t
index ba792f30a..2d7a95696 100755
--- a/test/args.5.t
+++ b/test/args.5.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 7;
+use Test::More tests => 5;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=off\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test 'stop' with en-passant changes.
@@ -77,11 +76,5 @@ like ($output, qr/Project\s+A/, 'stop enpassant project');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/args.t b/test/args.t
index 47d20c15a..82d135d33 100755
--- a/test/args.t
+++ b/test/args.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 7;
+use Test::More tests => 5;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'args.rc')
   print $fh "data.location=.\n",
             "confirmation=no\n";
   close $fh;
-  ok (-r 'args.rc', 'Created args.rc');
 }
 
 # Test the -- argument.
@@ -65,11 +64,5 @@ like ($output, qr/Description\s+project:p\spri:H\s\+tag\sfoo\n/ms, 'task 1 modif
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data args.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'args.rc', 'Cleanup');
-
 exit 0;