Portability

- Applied patch from Emil Sköldberg.

Replace 'test ... == ...' with 'test ... = ...',
since [quoted from pkgsrc error message]:

The "test" command, as well as the "[" command, are not required to know
the "==" operator. Only a few implementations like bash and some
versions of ksh support it.

When you run "test foo == foo" on a platform that does not support the
"==" operator, the result will be "false" instead of "true". This can
lead to unexpected behavior.
This commit is contained in:
Paul Beckingham 2010-03-25 17:36:43 -04:00
parent 2791578410
commit b6e9b84c80
3 changed files with 5 additions and 3 deletions

View file

@ -20,6 +20,7 @@ The following submitted code, packages or analysis, and deserve special thanks:
Steven de Brouwer
Pietro Cerutti
Alexander Neumann
Emil Sköldberg
Thanks to the following, who submitted detailed bug reports and excellent suggestions:
Eugene Kramer

View file

@ -6,6 +6,7 @@
message when called without an ID.
+ Summary report bar colors can now be specified with color.summary.bar
and color.summary.background configuration variables.
+ The configure script is more portable (thanks to Emil Sköldberg).
------ old releases ------------------------------

View file

@ -80,7 +80,7 @@ AC_ARG_WITH([ncurses-lib],
[ncurses_lib=$withval],
[ncurses_lib=''])
if test "x$with_ncurses" == "xyes" ; then
if test "x$with_ncurses" = "xyes" ; then
AC_DEFINE([HAVE_LIBNCURSES], [1], [Defined if you have libncurses])
if test -n "$ncurses_inc"; then
CFLAGS="$CFLAGS -I$ncurses_inc"
@ -111,7 +111,7 @@ fi
# [readline_lib=$withval],
# [readline_lib=''])
#
#if test "x$with_readline" == "xyes" ; then
#if test "x$with_readline" = "xyes" ; then
# AC_DEFINE([HAVE_LIBREADLINE], [1], [Defined if you have libreadline])
# if test -n "$readline_inc"; then
# CFLAGS="$CFLAGS -I$readline_inc"
@ -142,7 +142,7 @@ AC_ARG_WITH([lua-lib],
[lua_lib=$withval],
[lua_lib=''])
if test "x$with_lua" == "xyes" ; then
if test "x$with_lua" = "xyes" ; then
AC_DEFINE([HAVE_LIBLUA], [1], [Defined if you have liblua])
if test -n "$lua_inc"; then
CFLAGS="$CFLAGS -I$lua_inc"