GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "[clang-tidy] Use auto where the type is known"

Browse source 
This reverts commit 6ce2a129dd.
This commit is contained in:
Paul Beckingham 2020-12-05 16:18:15 -05:00
parent 0a3a4d364d
commit b2d46a1eba
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Hooks.cpp
View file

@ -485,7 +485,7 @@ void Hooks::assertSameTask (
for (auto& i : input) for (auto& i : input)
{ {
auto* root_obj = (json::object*)json::parse (i); json::object* root_obj = (json::object*)json::parse (i);
// If there is no UUID at all. // If there is no UUID at all.
auto u = root_obj->_data.find ("uuid"); auto u = root_obj->_data.find ("uuid");
@ -496,7 +496,7 @@ void Hooks::assertSameTask (
throw 0; throw 0;
} }
auto* up = (json::string*) u->second; json::string* up = (json::string*) u->second;
auto text = up->dump (); auto text = up->dump ();
Lexer::dequote (text); Lexer::dequote (text);
std::string json_uuid = json::decode (text); std::string json_uuid = json::decode (text);

16
src/Task.cpp
View file

@ -684,10 +684,10 @@ void Task::parseJSON (const json::object* root_obj)
// Tags are an array of JSON strings. // Tags are an array of JSON strings.
else if (i.first == "tags" && i.second->type() == json::j_array) else if (i.first == "tags" && i.second->type() == json::j_array)
{ {
auto* tags = (json::array*)i.second; json::array* tags = (json::array*)i.second;
for (auto& t : tags->_data) for (auto& t : tags->_data)
{ {
auto* tag = (json::string*)t; json::string* tag = (json::string*)t;
addTag (tag->_data); addTag (tag->_data);
} }
} }
@ -698,7 +698,7 @@ void Task::parseJSON (const json::object* root_obj)
// removed in a later release. // removed in a later release.
else if (i.first == "tags" && i.second->type() == json::j_string) else if (i.first == "tags" && i.second->type() == json::j_string)
{ {
auto* tag = (json::string*)i.second; json::string* tag = (json::string*)i.second;
addTag (tag->_data); addTag (tag->_data);
} }
@ -707,10 +707,10 @@ void Task::parseJSON (const json::object* root_obj)
// See other 2016-02-21 comments for details. // See other 2016-02-21 comments for details.
else if (i.first == "depends" && i.second->type() == json::j_array) else if (i.first == "depends" && i.second->type() == json::j_array)
{ {
auto* deps = (json::array*)i.second; json::array* deps = (json::array*)i.second;
for (auto& t : deps->_data) for (auto& t : deps->_data)
{ {
auto* dep = (json::string*)t; json::string* dep = (json::string*)t;
addDependency (dep->_data); addDependency (dep->_data);
} }
} }
@ -719,7 +719,7 @@ void Task::parseJSON (const json::object* root_obj)
// 2016-02-21: Deprecated - see other 2016-02-21 comments for details. // 2016-02-21: Deprecated - see other 2016-02-21 comments for details.
else if (i.first == "depends" && i.second->type() == json::j_string) else if (i.first == "depends" && i.second->type() == json::j_string)
{ {
auto* deps = (json::string*)i.second; json::string* deps = (json::string*)i.second;
auto uuids = split (deps->_data, ','); auto uuids = split (deps->_data, ',');
for (const auto& uuid : uuids) for (const auto& uuid : uuids)
@ -752,10 +752,10 @@ void Task::parseJSON (const json::object* root_obj)
{ {
std::map <std::string, std::string> annos; std::map <std::string, std::string> annos;
auto* atts = (json::array*)i.second; json::array* atts = (json::array*)i.second;
for (auto& annotations : atts->_data) for (auto& annotations : atts->_data)
{ {
auto* annotation = (json::object*)annotations; json::object* annotation = (json::object*)annotations;
json::string* when = (json::string*)annotation->_data["entry"]; json::string* when = (json::string*)annotation->_data["entry"];
json::string* what = (json::string*)annotation->_data["description"]; json::string* what = (json::string*)annotation->_data["description"];