GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-30 02:17:21 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Performance

Browse source 
- Found some inefficient string initialization in Table.cpp, report.cpp,
  and in switching over to using more std::string capabilities, realized
  a 25% boost in Table::render speed.
- Eliminated Table::suppressWS.
- Eliminated Table::clean.
This commit is contained in:
Paul Beckingham 2010-07-06 01:37:35 -04:00
parent 25db00e97d
commit ad9c89b9fb
3 changed files with 41 additions and 147 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/report.cpp
View file

@ -706,24 +706,13 @@ int handleReportSummary (std::string &outs)
std::string subbar;
if (context.config.getBoolean ("color") || context.config.getBoolean ("_forcecolor"))
{
for (int b = 0; b < completedBar; ++b)
subbar += " ";
bar += bar_color.colorize (subbar);
subbar = "";
for (int b = 0; b < barWidth - completedBar; ++b)
subbar += " ";
bar += bg_color.colorize (subbar);
bar += bar_color.colorize (std::string ( completedBar, ' '));
bar += bg_color.colorize (std::string (barWidth - completedBar, ' '));
}
else
{
for (int b = 0; b < completedBar; ++b)
bar += "=";
for (int b = 0; b < barWidth - completedBar; ++b)
bar += " ";
bar += std::string ( completedBar, '=')
+ std::string (barWidth - completedBar, ' ');
}
table.addCell (row, 4, bar);
@ -1347,8 +1336,7 @@ int handleReportGHistoryMonthly (std::string &outs)
dBar = " " + dBar;
}
while (bar.length () < leftOffset - aBar.length ())
bar += " ";
bar += std::string (leftOffset - aBar.length (), ' ');
bar += color_add.colorize (aBar);
bar += color_done.colorize (cBar);
@ -1360,9 +1348,7 @@ int handleReportGHistoryMonthly (std::string &outs)
std::string cBar = ""; while (cBar.length () < completedBar) cBar += "X";
std::string dBar = ""; while (dBar.length () < deletedBar) dBar += "-";
while (bar.length () < leftOffset - aBar.length ())
bar += " ";
bar += std::string (leftOffset - aBar.length (), ' ');
bar += aBar + cBar + dBar;
}
@ -1554,9 +1540,7 @@ int handleReportGHistoryAnnual (std::string &outs)
dBar = " " + dBar;
}
while (bar.length () < leftOffset - aBar.length ())
bar += " ";
bar += std::string (leftOffset - aBar.length (), ' ');
bar += color_add.colorize (aBar);
bar += color_done.colorize (cBar);
bar += color_delete.colorize (dBar);
@ -1567,9 +1551,7 @@ int handleReportGHistoryAnnual (std::string &outs)
std::string cBar = ""; while (cBar.length () < completedBar) cBar += "X";
std::string dBar = ""; while (dBar.length () < deletedBar) dBar += "-";
while (bar.length () < leftOffset - aBar.length ())
bar += " ";
bar += std::string (leftOffset - aBar.length (), ' ');
bar += aBar + cBar + dBar;
}