GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Enhancements - TDB::mId

Browse source 
- Implemented ID assignment.
- Removed unnecessary constructors.
This commit is contained in:
Paul Beckingham 2009-06-11 20:30:54 -04:00
parent 754b79afb2
commit ac9dae9af8
2 changed files with 8 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/TDB2.cpp
View file

@ -68,42 +68,10 @@
TDB2::TDB2 () TDB2::TDB2 ()
: mLock (true) : mLock (true)
, mAllOpenAndLocked (false) , mAllOpenAndLocked (false)
, mId (1)
{ {
} }
////////////////////////////////////////////////////////////////////////////////
TDB2::TDB2 (const TDB2& other)
{
throw std::string ("unimplemented TDB2::TDB2");
// mLocations = other.mLocations;
// mFiles = other.mFiles;
// mLock = other.mLock;
// mAllOpenAndLocked = false; // Deliberately so.
//
// // Set all to NULL, otherwise we are duplicating open file handles.
// foreach (file, mFiles)
// mFiles[file->first] = NULL;
}
////////////////////////////////////////////////////////////////////////////////
TDB2& TDB2::operator= (const TDB2& other)
{
throw std::string ("unimplemented TDB2::operator=");
// if (this != &other)
// {
// mLocations = other.mLocations;
// mFiles = other.mFiles;
// mLock = other.mLock;
// mAllOpenAndLocked = false; // Deliberately so.
//
// // Set all to NULL, otherwise we are duplicating open file handles.
// foreach (file, mFiles)
// mFiles[file->first] = NULL;
// }
//
return *this;
}
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
TDB2::~TDB2 () TDB2::~TDB2 ()
{ {
@ -205,6 +173,8 @@ int TDB2::loadPending (std::vector <Task>& tasks, Filter& filter)
// TODO Add hidden attribute indicating source? // TODO Add hidden attribute indicating source?
line[length - 1] = '\0'; // Kill \n line[length - 1] = '\0'; // Kill \n
Task task (line); Task task (line);
task.id (mId++);
if (filter.pass (task)) if (filter.pass (task))
tasks.push_back (task); tasks.push_back (task);
} }
@ -255,6 +225,8 @@ int TDB2::loadCompleted (std::vector <Task>& tasks, Filter& filter)
// TODO Add hidden attribute indicating source? // TODO Add hidden attribute indicating source?
line[length - 1] = '\0'; // Kill \n line[length - 1] = '\0'; // Kill \n
Task task (line); Task task (line);
task.id (mId++);
if (filter.pass (task)) if (filter.pass (task))
tasks.push_back (task); tasks.push_back (task);
} }

7
src/TDB2.h
View file

@ -40,10 +40,8 @@
class TDB2 class TDB2
{ {
public: public:
TDB2 (); // Default constructor TDB2 (); // Default constructor
TDB2 (const TDB2&); // Copy constructor ~TDB2 (); // Destructor
TDB2& operator= (const TDB2&); // Assignment operator
~TDB2 (); // Destructor
void clear (); void clear ();
void location (const std::string&); void location (const std::string&);
@ -66,6 +64,7 @@ private:
std::vector <Location> mLocations; std::vector <Location> mLocations;
bool mLock; bool mLock;
bool mAllOpenAndLocked; bool mAllOpenAndLocked;
int mId;
// TODO Need cache of raw file contents to preserve comments. // TODO Need cache of raw file contents to preserve comments.
}; };