From abb663fae30dd61fcdd339368ce669cf09d9bf66 Mon Sep 17 00:00:00 2001
From: Paul Beckingham <paul@beckingham.net>
Date: Sun, 1 Jun 2014 10:22:05 -0400
Subject: [PATCH] Unit Tests

- Removed useless setup/teardown tests, improving the signal to noise ratio.
---
 test/datesort.t     |  9 +--------
 test/default.t      |  9 +--------
 test/delete.t       |  9 +--------
 test/dependencies.t | 11 +----------
 test/dom.2.t        |  9 +--------
 test/due.t          |  9 +--------
 test/duplicate.t    |  9 +--------
 test/duplicate2.t   |  9 +--------
 8 files changed, 8 insertions(+), 66 deletions(-)

diff --git a/test/datesort.t b/test/datesort.t
index 32c86d43d..55b952d30 100755
--- a/test/datesort.t
+++ b/test/datesort.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 4;
+use Test::More tests => 2;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -46,7 +46,6 @@ if (open my $fh, '>', 'datesort.rc')
             "report.small_list.dateformat=MD\n";
 
   close $fh;
-  ok (-r 'datesort.rc', 'Created datesort.rc');
 }
 
 qx{../src/task rc:datesort.rc add two   due:20100201 2>&1};
@@ -61,11 +60,5 @@ like ($output, qr/three.+two.+one/ms, 'Sorting by due- with format MD works');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data datesort.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'datesort.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/default.t b/test/default.t
index 527e8c4ca..8774df78a 100755
--- a/test/default.t
+++ b/test/default.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 21;
+use Test::More tests => 19;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -43,7 +43,6 @@ if (open my $fh, '>', 'default.rc')
             "default.due=eom\n",
             "dateformat=m/d/Y\n";
   close $fh;
-  ok (-r 'default.rc', 'Created default.rc');
 }
 
 # Set up a default command, project and priority.
@@ -89,11 +88,5 @@ unlike ($output, qr/ L /, 'priority:L excluded from default command');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data default.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'default.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/delete.t b/test/delete.t
index 2313c0507..f9fdee5e4 100755
--- a/test/delete.t
+++ b/test/delete.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 14;
+use Test::More tests => 12;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -39,7 +39,6 @@ if (open my $fh, '>', 'delete.rc')
   print $fh "data.location=.\n",
             "confirmation=no\n";
   close $fh;
-  ok (-r 'delete.rc', 'Created delete.rc');
 }
 
 # Add a task, delete it, undelete it.
@@ -82,11 +81,5 @@ like ($output, qr/Deleted/, 'task added, completed, then deleted');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data delete.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'delete.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/dependencies.t b/test/dependencies.t
index 7ac12eb4d..00ad07ee9 100755
--- a/test/dependencies.t
+++ b/test/dependencies.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 49;
+use Test::More tests => 47;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -43,9 +43,6 @@ if (open my $fh, '>', 'dep.rc')
   print $fh "report.depreport.filter=status:pending\n";
   print $fh "report.depreport.sort=depends+\n";
   close $fh;
-
-  # [1]
-  ok (-r 'dep.rc', 'Created dep.rc');
 }
 
 qx{../src/task rc:dep.rc add One 2>&1};
@@ -261,11 +258,5 @@ unlike ($output, qr/test5/ms, 'Dependency not appearing for task5');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data dep.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'dep.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/dom.2.t b/test/dom.2.t
index 4c14f23c5..6da337ab1 100755
--- a/test/dom.2.t
+++ b/test/dom.2.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 6;
+use Test::More tests => 4;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -40,7 +40,6 @@ if (open my $fh, '>', 'dom.rc')
             "dateformat=YMD\n",
             "dateformat.info=YMD\n";
   close $fh;
-  ok (-r 'dom.rc', 'Created dom.rc');
 }
 
 # DOM reference to other task.
@@ -63,11 +62,5 @@ like ($output, qr/^1$/, 'DOM uuid --> id');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data dom.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'dom.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/due.t b/test/due.t
index c878e615e..f6f205e48 100755
--- a/test/due.t
+++ b/test/due.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 6;
+use Test::More tests => 4;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -44,7 +44,6 @@ if (open my $fh, '>', 'due.rc')
             "_forcecolor=on\n",
             "dateformat=m/d/Y\n";
   close $fh;
-  ok (-r 'due.rc', 'Created due.rc');
 }
 
 # Add a task that is almost due, and one that is just due.
@@ -69,11 +68,5 @@ like ($output, qr/three/, 'due.is:today works as a filter');
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data due.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'due.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/duplicate.t b/test/duplicate.t
index 765717063..c897d7ad1 100755
--- a/test/duplicate.t
+++ b/test/duplicate.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 12;
+use Test::More tests => 10;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -38,7 +38,6 @@ if (open my $fh, '>', 'dup.rc')
 {
   print $fh "data.location=.\n";
   close $fh;
-  ok (-r 'dup.rc', 'Created dup.rc');
 }
 
 # Test the duplicate command.
@@ -65,11 +64,5 @@ like ($output, qr/Created\s+task\s+4/,         'duplicate output of new task id'
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data dup.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'dup.rc', 'Cleanup');
-
 exit 0;
 
diff --git a/test/duplicate2.t b/test/duplicate2.t
index 8c01627de..18e3bc1c9 100755
--- a/test/duplicate2.t
+++ b/test/duplicate2.t
@@ -27,7 +27,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 14;
+use Test::More tests => 12;
 
 # Ensure environment has no influence.
 delete $ENV{'TASKDATA'};
@@ -38,7 +38,6 @@ if (open my $fh, '>', 'dup.rc')
 {
   print $fh "data.location=.\n";
   close $fh;
-  ok (-r 'dup.rc', 'Created dup.rc');
 }
 
 # Add a recurring task.  Duplicate both parent and child.
@@ -76,11 +75,5 @@ like ($output, qr/Parent/,                     'Found duplicated child task - wi
 
 # Cleanup.
 unlink qw(pending.data completed.data undo.data backlog.data dup.rc);
-ok (! -r 'pending.data'   &&
-    ! -r 'completed.data' &&
-    ! -r 'undo.data'      &&
-    ! -r 'backlog.data'   &&
-    ! -r 'dup.rc', 'Cleanup');
-
 exit 0;