GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[clang-tidy] Use const reference instead of initializing string

Browse source 
Found with performance-unnecessary-copy-initialization

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2019-09-27 20:31:21 -07:00 • committed by Paul Beckingham
parent e3ceda9ce1
commit ab170e34df
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/sort.cpp
View file

@ -242,7 +242,7 @@ static bool sort_compare (int left, int right)
// UDAs. // UDAs.
else if ((column = Context::getContext ().columns[field]) != nullptr) else if ((column = Context::getContext ().columns[field]) != nullptr)
{ {
std::string type = column->type (); const std::string& type = column->type ();
if (type == "numeric") if (type == "numeric")
{ {
auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr); auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr);