GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[clang-tidy] using dynamic_cast for derived classes

Browse source 
Found with cppcoreguidelines-pro-type-cstyle-cast

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2019-09-27 21:00:49 -07:00 • committed by Paul Beckingham
parent 51870dff34
commit a02754159c
2 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Hooks.cpp
View file

@ -432,13 +432,13 @@ void Hooks::assertValidJSON (
throw 0;
}
if (((json::object*)root)->_data.find ("description") == ((json::object*)root)->_data.end ())
if ((dynamic_cast<json::object*>(root))->_data.find ("description") == (dynamic_cast<json::object*>(root))->_data.end ())
{
Context::getContext ().error (format (STRING_HOOK_ERROR_NODESC, Path (script).name ()));
throw 0;
}
if (((json::object*)root)->_data.find ("uuid") == ((json::object*)root)->_data.end ())
if ((dynamic_cast<json::object*>(root))->_data.find ("uuid") == (dynamic_cast<json::object*>(root))->_data.end ())
{
Context::getContext ().error (format (STRING_HOOK_ERROR_NOUUID, Path (script).name ()));
throw 0;
@ -486,7 +486,7 @@ void Hooks::assertSameTask (
for (auto& i : input)
{
auto* root_obj = (json::object*)json::parse (i);
auto* root_obj = dynamic_cast<json::object*>(json::parse (i));
// If there is no UUID at all.
auto u = root_obj->_data.find ("uuid");
@ -497,7 +497,7 @@ void Hooks::assertSameTask (
throw 0;
}
auto* up = (json::string*) u->second;
auto* up = dynamic_cast<json::string*>( u->second);
auto text = up->dump ();
Lexer::dequote (text);
std::string json_uuid = json::decode (text);