GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

UDA: indicator column did not properly default to 'U'

Browse source 
- Thanks to JDufault.
This commit is contained in:
Paul Beckingham 2015-12-16 14:57:58 -05:00
parent c7b792bf47
commit 900ad3c26b
3 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
AUTHORS
View file

@ -278,3 +278,4 @@ suggestions:
Naga Kiran Naga Kiran
David Badura David Badura
James Dietrich James Dietrich
JDufault

1
ChangeLog
View file

@ -31,6 +31,7 @@
- Fixed broken build for Cygwin and older GCC (thanks to Richard Boß). - Fixed broken build for Cygwin and older GCC (thanks to Richard Boß).
- The default configuration is now 256-color only. - The default configuration is now 256-color only.
- The 'columns' report now shows whether a column is modifiable or read only. - The 'columns' report now shows whether a column is modifiable or read only.
- UDA indicator column did not properly default to 'U' (thanks to JDufault).
- Numerous performance improvements. Taskwarrior 2.5.1 is between X% and - Numerous performance improvements. Taskwarrior 2.5.1 is between X% and
Y% faster than 2.5.0 when running various commands. Y% faster than 2.5.0 when running various commands.

16
src/columns/ColUDA.cpp
View file

@ -116,7 +116,13 @@ void ColumnUDA::measure (Task& task, unsigned int& minimum, unsigned int& maximu
else if (_style == "indicator") else if (_style == "indicator")
{ {
if (task.has (_name)) if (task.has (_name))
minimum = maximum = utf8_width (context.config.get ("uda." + _name + ".indicator")); {
auto indicator = context.config.get ("uda." + _name + ".indicator");
if (indicator == "")
indicator = "U";
minimum = maximum = utf8_width (indicator);
}
else else
minimum = maximum = 0; minimum = maximum = 0;
} }
@ -171,7 +177,13 @@ void ColumnUDA::render (
else if (_style == "indicator") else if (_style == "indicator")
{ {
if (task.has (_name)) if (task.has (_name))
renderStringRight (lines, width, color, context.config.get ("uda." + _name + ".indicator")); {
auto indicator = context.config.get ("uda." + _name + ".indicator");
if (indicator == "")
indicator = "U";
renderStringRight (lines, width, color, indicator);
}
} }
} }
} }