GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

dependency: CPP Core Guidlines compliance

Browse source
This commit is contained in:
Paul Beckingham 2017-03-02 20:56:19 -05:00
parent 42e0c17de7
commit 88968af20b
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/dependency.cpp
View file

@ -57,8 +57,8 @@ std::vector <Task> dependencyGetBlocked (const Task& task)
std::vector <Task> dependencyGetBlocking (const Task& task)
{
auto depends = task.get ("depends");
std::vector <Task> blocking;
std::vector <Task> blocking;
if (depends != "")
for (auto& it : context.tdb2.pending.get_tasks ())
if (it.getStatus () != Task::completed &&
@ -80,9 +80,9 @@ bool dependencyIsCircular (const Task& task)
auto task_uuid = task.get ("uuid");
std::stack <Task> s;
std::unordered_set <std::string> visited;
s.push (task);
std::unordered_set <std::string> visited;
visited.insert (task_uuid);
while (! s.empty ())
@ -164,7 +164,7 @@ void dependencyChainOnComplete (Task& task)
std::cout << format (STRING_DEPEND_BLOCKED, task.identifier ())
<< '\n';
for (auto& b : blocking)
for (const auto& b : blocking)
std::cout << " " << b.id << ' ' << b.get ("description") << '\n';
}
@ -176,7 +176,7 @@ void dependencyChainOnComplete (Task& task)
std::cout << STRING_DEPEND_BLOCKING
<< '\n';
for (auto& b : blocked)
for (const auto& b : blocked)
std::cout << " " << b.id << ' ' << b.get ("description") << '\n';
}
@ -189,7 +189,7 @@ void dependencyChainOnComplete (Task& task)
{
left.removeDependency (task.id);
for (auto& right : blocking)
for (const auto& right : blocking)
left.addDependency (right.id);
}
@ -218,7 +218,7 @@ void dependencyChainOnStart (Task& task)
std::cout << format (STRING_DEPEND_BLOCKED, task.identifier ())
<< '\n';
for (auto& b : blocking)
for (const auto& b : blocking)
std::cout << " " << b.id << ' ' << b.get ("description") << '\n';
}
}