GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Bug #605

Browse source 
+ Fixed bug #605, which gave misleading project completion percentages under
  certain circumstances (thanks to Steve Rader).
This commit is contained in:
Paul Beckingham 2011-04-24 11:36:43 -04:00
parent 5f8b3cf989
commit 86ef048cb0
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -35,6 +35,8 @@
+ Added feature #714, including Belarus holidays (thanks to Alexei Romanoff). + Added feature #714, including Belarus holidays (thanks to Alexei Romanoff).
# Tracked Bugs, sorted by ID. # Tracked Bugs, sorted by ID.
+ Fixed bug #605, which gave misleading project completion percentages under
certain circumstances (thanks to Steve Rader).
+ Fixed bug #703, where global substitutions didn't make all expected + Fixed bug #703, where global substitutions didn't make all expected
annotation changes. annotation changes.
+ Fixed bug #707, which had inverted logic with the urgency calculation for + Fixed bug #707, which had inverted logic with the urgency calculation for

12
src/report.cpp
View file

@ -2194,8 +2194,18 @@ std::string onProjectChange (Task& task, bool scope /* = true */)
countTasks (all, project, context.tdb.getAllModified (), count_pending, count_done); countTasks (all, project, context.tdb.getAllModified (), count_pending, count_done);
countTasks (context.tdb.getAllModified (), project, (std::vector <Task>) NULL, count_pending, count_done); countTasks (context.tdb.getAllModified (), project, (std::vector <Task>) NULL, count_pending, count_done);
// count_done count_pending percentage
// ---------- ------------- ----------
// 0 0 0%
// >0 0 100%
// 0 >0 0%
// >0 >0 calculated
int percentage = 0; int percentage = 0;
if (count_done + count_pending > 0) if (count_done == 0)
percentage = 0;
else if (count_pending == 0)
percentage = 100;
else
percentage = (count_done * 100 / (count_done + count_pending)); percentage = (count_done * 100 / (count_done + count_pending));
msg << "Project '" msg << "Project '"