applyOverrides: add messages after overrides

src/CLI2.cpp

@@ -272,36 +272,35 @@ void CLI2::getDataLocation (int argc, const char** argv, Path& data)
 // Static method.
 void CLI2::applyOverrides (int argc, const char** argv)
 {
-  for (int i = 0; i < argc; ++i)
+  auto& context = Context::getContext ();
+  auto last = std::find (argv, argv + argc, std::string ("--"));
+  auto is_override = [] (const std::string& s)
   {
-
+    return s.compare (0, 3, "rc.") == 0;
-    // Don't process any arguments after a '--'
+  };
-    std::string raw = argv[i];
+  auto get_sep = [&] (const std::string& s)
-    if (raw == "--")
-      break;
-
-    // Overrides always start with 'rc.'
-    if (raw.length () > 3 &&
-        raw.substr (0, 3) == "rc.")
   {
-
+    if (is_override (s))
-      // Our separator can either be '=' or ':', so try and find both.
+      return s.find_first_of (":=", 3);
-      auto sep = raw.find ('=', 3);
+    return std::string::npos;
+  };
+  auto override_settings = [&] (std::string raw)
+  {
+    auto sep = get_sep (raw);
     if (sep == std::string::npos)
-        sep = raw.find (':', 3);
+      return;
-
-      // Process our override if well-formed
-      if (sep != std::string::npos)
-      {
     std::string name  = raw.substr (3, sep - 3);
     std::string value = raw.substr (sep + 1);
-        Context::getContext ().config.set (name, value);
+    context.config.set (name, value);
-
+  };
-        if (Context::getContext ().verbose("override"))
+  auto display_overrides = [&] (std::string raw)
-          Context::getContext ().footnote (format ("Configuration override rc.{1}:{2}", name, value));
+  {
-      }
+    if (is_override (raw))
-    }
+      context.footnote (format ("Configuration override {1}", raw));
-  }
+  };
+  std::for_each (argv, last, override_settings);
+  if (context.verbose ("override"))
+    std::for_each (argv, last, display_overrides);
 }
 
 ////////////////////////////////////////////////////////////////////////////////