GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

TW-1423

Browse source 
- TW-1423 Using the date February 29th, in a non leap year does not fail well
          (thanks to Black Ops Testing).
This commit is contained in:
Paul Beckingham 2014-12-24 09:03:49 -05:00
parent 2c1f18bf26
commit 84dc7dd245
3 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -172,6 +172,8 @@
Black Ops Testing). Black Ops Testing).
- TW-1422 Attempt to modify 'id' attribute creates an id attribute (thanks to - TW-1422 Attempt to modify 'id' attribute creates an id attribute (thanks to
Black Ops Testing). Black Ops Testing).
- TW-1423 Using the date February 29th, in a non leap year does not fail well
(thanks to Black Ops Testing).
- TW-1424 Using a date of '1824days' (in the future) fails (thanks to Black Ops - TW-1424 Using a date of '1824days' (in the future) fails (thanks to Black Ops
Testing). Testing).
- TW-1428 Add support for color.uda.<name>.<value> rules. - TW-1428 Add support for color.uda.<name>.<value> rules.

5
src/Task.cpp
View file

@ -2008,6 +2008,11 @@ void Task::modify (modType type, bool text_required /* = false */)
context.debug (label + name + " <-- '" + format ("{1}", v.get_date ()) + "' <-- '" + (std::string) v + "' <-- '" + value + "'"); context.debug (label + name + " <-- '" + format ("{1}", v.get_date ()) + "' <-- '" + (std::string) v + "' <-- '" + value + "'");
} }
// If a date doesn't parse (2/29/2014) then it evaluates to zero.
if (value != "" &&
v.get_date () == 0)
throw format (STRING_DATE_INVALID_FORMAT, value, Variant::dateFormat);
set (name, v.get_date ()); set (name, v.get_date ());
++modCount; ++modCount;
} }

3
test/bug.360.t
View file

@ -99,8 +99,7 @@ class TestBug360AllowedChanges(BaseTestBug360):
self.t(("add", "nonrecurring", "due:today")) self.t(("add", "nonrecurring", "due:today"))
def test_allow_modify_due_in_nonrecurring(self): def test_allow_modify_due_in_nonrecurring(self):
"""Allow modifying due date in non recurring task """Allow modifying due date in non recurring task"""
"""
# Retrieve the id of the non recurring task # Retrieve the id of the non recurring task
args = ("ls",) args = ("ls",)
code, out, err = self.t(args) code, out, err = self.t(args)