Logic Bug

- Fixed logic bug in bulk and recurring task modifications.

src/commands/CmdModify.cpp

@@ -25,7 +25,6 @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 
-
 #define L10N                                           // Localization complete.
 
 #include <iostream>
@@ -34,6 +33,7 @@
 #include <Permission.h>
 #include <main.h>
 #include <text.h>
+#include <util.h>
 #include <i18n.h>
 #include <CmdModify.h>
 
@@ -52,6 +52,7 @@ CmdModify::CmdModify ()
 ////////////////////////////////////////////////////////////////////////////////
 int CmdModify::execute (std::string& output)
 {
+  int rc = 0;
   int count = 0;
   std::stringstream out;
 
@@ -102,79 +103,76 @@ int CmdModify::execute (std::string& output)
          task->get ("recur") == ""))
       throw std::string (STRING_CMD_MODIFY_REC_ALWAYS);
 
-    if (taskDiff (before, *task) &&
+    // Delete the specified task.
-        permission.confirmed (*task, taskDifferences (before, *task) + "Proceed with change?"))
+    std::string question = format (STRING_CMD_MODIFY_QUESTION,
+                                   task->id,
+                                   task->get ("description"));
+
+    if (permission.confirmed (*task, taskDifferences (before, *task) + question))
     {
-      // Checks passed, modify the task.
+      updateRecurrenceMask (*task);
-      ++count;
       context.tdb2.modify (*task);
-      if (before.get ("project") != task->get ("project"))
+      ++count;
-        context.footnote (onProjectChange (before, *task));
 
-      // Make all changes.
+      if (context.verbose ("affected") ||
-      bool warned = false;
+          context.config.getBoolean ("echo.command")) // Deprecated 2.0
-      std::vector <Task> siblings = context.tdb2.siblings (*task);
+        out << format (task->has ("parent")
-      std::vector <Task>::iterator sibling;
+                         ? STRING_CMD_MODIFY_RECURRING
-      for (sibling = siblings.begin (); sibling != siblings.end (); ++sibling)
+                         : STRING_CMD_MODIFY_SIMPLE,
+                       task->id,
+                       task->get ("description"))
+            << "\n";
+
+      dependencyChainOnModify (before, *task);
+      context.footnote (onProjectChange (*task, true));
+
+      // Delete siblings.
+      if (task->has ("parent"))
       {
-        if (before.has ("parent") && !warned)
+        std::vector <Task> siblings = context.tdb2.siblings (*task);
+        if (siblings.size () &&
+            confirm (STRING_CMD_MODIFY_RECUR))
         {
-          warned = true;
+          std::vector <Task>::iterator sibling;
-          std::cout << format (STRING_CMD_MODIFY_INSTANCES, before.id) << "\n";
+          for (sibling = siblings.begin (); sibling != siblings.end (); ++sibling)
-        }
-
-        Task alternate (*sibling);
-
-        // If a task is being made recurring, there are other cascading
-        // changes.
-        if (!before.has ("recur") &&
-            task->has ("recur"))
-        {
-          sibling->setStatus (Task::recurring);
-          sibling->set ("mask", "");
-
-          std::cout << format (STRING_CMD_MODIFY_NOW_RECUR, sibling->id) << "\n";
-        }
-
-        // Apply other deltas.
-        modify_task_description_replace (*sibling, modifications);
-
-        if (taskDiff (alternate, *sibling))
-        {
-          if (permission.confirmed (alternate,
-                                    taskDifferences (alternate, *sibling) +
-                                                     STRING_CMD_MODIFY_PROCEED))
           {
-            // TODO Are dependencies being explicitly removed?
+            Task alternate (*sibling);
-            //      Either we scan context.task for negative IDs "depends:-n"
+            modify_task_description_replace (*sibling, modifications);
-            //      or we ask deltaAttributes (above) to record dependency
+            updateRecurrenceMask (*sibling);
-            //      removal.
-            dependencyChainOnModify (alternate, *sibling);
             context.tdb2.modify (*sibling);
+            dependencyChainOnModify (alternate, *sibling);
+            context.footnote (onProjectChange (*sibling, true));
             ++count;
 
-            if (alternate.get ("project") != sibling->get ("project"))
+            if (context.verbose ("affected") ||
-              context.footnote (onProjectChange (alternate, *sibling));
+                context.config.getBoolean ("echo.command")) // Deprecated 2.0
-
+              out << format (STRING_CMD_MODIFY_RECURRING,
+                             sibling->id,
+                             sibling->get ("description"))
+                  << "\n";
           }
         }
       }
     }
+    else
+    {
+      out << STRING_CMD_MODIFY_NOT << "\n";
+      rc  = 1;
+    }
   }
 
   context.tdb2.commit ();
 
   if (context.verbose ("affected") ||
       context.config.getBoolean ("echo.command")) // Deprecated 2.0
-  {
+    out << format ((count == 1
-    if (count == 1)
+                      ? STRING_CMD_MODIFY_TASK
-      out << format (STRING_CMD_MODIFY_TASK, count) << "\n";
+                      : STRING_CMD_MODIFY_TASKS),
-    else
+                   count)
-      out << format (STRING_CMD_MODIFY_TASKS, count) << "\n";
+        << "\n";
-  }
 
   output = out.str ();
-  return 0;
+  return rc;
 }
 
 ////////////////////////////////////////////////////////////////////////////////