GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

CmdUnique: Code cleanup

Browse source
This commit is contained in:
Paul Beckingham 2017-01-28 17:08:07 -05:00
parent 670a215743
commit 82cd74906b
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/commands/CmdUnique.cpp
View file

@ -63,7 +63,7 @@ int CmdUnique::execute (std::string& output)
filter.subset (filtered); filter.subset (filtered);
// Find <attribute>. // Find <attribute>.
std::string attribute = ""; std::string attribute {};
// Just the first arg. // Just the first arg.
auto words = context.cli2.getWords (); auto words = context.cli2.getWords ();
@ -75,17 +75,23 @@ int CmdUnique::execute (std::string& output)
if (! context.cli2.canonicalize (canonical, "attribute", attribute)) if (! context.cli2.canonicalize (canonical, "attribute", attribute))
throw std::string (STRING_CMD_UNIQUE_VALID); throw std::string (STRING_CMD_UNIQUE_VALID);
// Find number of matching tasks. // Find the unique set of matching tasks.
std::set <std::string> values; std::set <std::string> values;
for (auto& task : filtered) for (auto& task : filtered)
{
if (task.has (canonical)) if (task.has (canonical))
{
values.insert (task.get (canonical)); values.insert (task.get (canonical));
}
else if (canonical == "id" && else if (canonical == "id" &&
task.getStatus () != Task::deleted && task.getStatus () != Task::deleted &&
task.getStatus () != Task::completed) task.getStatus () != Task::completed)
{
values.insert (format (task.id)); values.insert (format (task.id));
}
}
// Generate list of unique values. // Generate list of values.
for (auto& value : values) for (auto& value : values)
output += value + '\n'; output += value + '\n';