Unit Tests

- Removed useless setup/teardown tests, improving the signal to noise ratio.
This commit is contained in:
Paul Beckingham 2014-06-01 09:49:57 -04:00
parent a59f8644f1
commit 7ab8d4db6d
7 changed files with 7 additions and 56 deletions

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 26; use Test::More tests => 24;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -87,11 +86,5 @@ unlike ($output, qr/four/, 'ls project:A priority:H --> !four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 26; use Test::More tests => 24;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -87,11 +86,5 @@ unlike ($output, qr/four/, 'ls urgency > 10 --> !four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 14; use Test::More tests => 12;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -69,11 +68,5 @@ unlike ($output, qr/four/, 'ls urgency >= 2.0 --> !four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 26; use Test::More tests => 24;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -87,11 +86,5 @@ like ($output, qr/four/, 'ls description < 10 --> four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 14; use Test::More tests => 12;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -69,11 +68,5 @@ like ($output, qr/four/, 'ls urgency <= 2.0 --> four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 18; use Test::More tests => 16;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -75,11 +74,5 @@ unlike ($output, qr/four/, 'ls project=A or priority=H --> !four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;

View file

@ -27,7 +27,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 18; use Test::More tests => 16;
# Ensure environment has no influence. # Ensure environment has no influence.
delete $ENV{'TASKDATA'}; delete $ENV{'TASKDATA'};
@ -39,7 +39,6 @@ if (open my $fh, '>', 'op.rc')
print $fh "data.location=.\n", print $fh "data.location=.\n",
"confirmation=no\n"; "confirmation=no\n";
close $fh; close $fh;
ok (-r 'op.rc', 'Created op.rc');
} }
# Setup: Add a task # Setup: Add a task
@ -75,11 +74,5 @@ unlike ($output, qr/four/, 'ls project=A priority=H --> !four');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data op.rc); unlink qw(pending.data completed.data undo.data backlog.data op.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'op.rc', 'Cleanup');
exit 0; exit 0;