GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix compiler warning about unused variable (#3873)

Browse source 
This was added to indicate that the return value of chdir was unused,
but newer compilers "see through" this and determine it to be unused.
The return value is not marked must-use, so just doing nothing with it
is sufficient.
This commit is contained in:
Dustin J. Mitchell 2025-05-08 13:08:22 -04:00 • committed by GitHub
parent 0e59a62ead
commit 79eb38d582
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/commands/CmdEdit.cpp
View file

@ -619,10 +619,9 @@ CmdEdit::editResult CmdEdit::editFile(Task& task) {
auto dateformat = Context::getContext().config.get("dateformat.edit");
if (dateformat == "") dateformat = Context::getContext().config.get("dateformat");
// Change directory for the editor
// Change directory for the editor, doing nothing on error.
auto current_dir = Directory::cwd();
int ignored = chdir(location._data.c_str());
++ignored; // Keep compiler quiet.
chdir(location._data.c_str());
// Check if the file already exists, if so, bail out
Path filepath = Path(file.str());
@ -702,7 +701,7 @@ ARE_THESE_REALLY_HARMFUL:
// Cleanup.
File::remove(file.str());
ignored = chdir(current_dir.c_str());
chdir(current_dir.c_str());
return changes ? CmdEdit::editResult::changes : CmdEdit::editResult::nochanges;
}