GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-07-07 20:06:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Column: Removed ::can_modify, which is moot

Browse source
This commit is contained in:
Paul Beckingham 2015-10-31 11:14:23 -04:00
parent 2ff8d8329f
commit 6baff92b5a
3 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Task.cpp
View file

@ -2181,6 +2181,7 @@ void Task::modify (modType type, bool text_required /* = false */)
std::string strValue = (std::string) evaluatedValue; std::string strValue = (std::string) evaluatedValue;
if (column->validate (strValue)) if (column->validate (strValue))
{ {
/*
if (column->can_modify ()) if (column->can_modify ())
{ {
std::string col_value = column->modify (strValue); std::string col_value = column->modify (strValue);
@ -2189,9 +2190,12 @@ void Task::modify (modType type, bool text_required /* = false */)
} }
else else
{ {
*/
context.debug (label + name + " <-- '" + strValue + "' <-- '" + value + "'"); context.debug (label + name + " <-- '" + strValue + "' <-- '" + value + "'");
(*this).set (name, strValue); (*this).set (name, strValue);
/*
} }
*/
++modCount; ++modCount;
} }

7
src/columns/Column.cpp
View file

@ -265,10 +265,3 @@ bool Column::validate (std::string& input)
} }
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// No L10N.
bool Column::can_modify ()
{
return false;
}
////////////////////////////////////////////////////////////////////////////////

1
src/columns/Column.h
View file

@ -63,7 +63,6 @@ public:
virtual void renderHeader (std::vector <std::string>&, int, Color&); virtual void renderHeader (std::vector <std::string>&, int, Color&);
virtual void render (std::vector <std::string>&, const std::string&, int, Color&) {}; virtual void render (std::vector <std::string>&, const std::string&, int, Color&) {};
virtual void render (std::vector <std::string>&, Task&, int, Color&) {}; virtual void render (std::vector <std::string>&, Task&, int, Color&) {};
virtual bool can_modify ();
virtual std::string modify (std::string& input) { return input; }; virtual std::string modify (std::string& input) { return input; };
protected: protected: