GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[clang-tidy] match loop size with size()

Browse source 
Found with bugprone-too-small-loop-variable

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2019-09-27 21:15:03 -07:00 • committed by Paul Beckingham
parent a02754159c
commit 68c446ea08
3 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/CLI2.cpp
View file

@ -330,7 +330,7 @@ void CLI2::add (const std::vector <std::string>& arguments)
for (const auto& arg : arguments)
replacement.emplace_back(arg, Lexer::Type::word);
for (unsigned int i = 1; i < _original_args.size (); ++i)
for (std::size_t i = 1; i < _original_args.size (); ++i)
replacement.push_back (_original_args[i]);
_original_args = replacement;
@ -385,7 +385,7 @@ void CLI2::lexArguments ()
// Note: Starts iterating at index 1, because ::handleArg0 has already
// processed it.
bool terminated = false;
for (unsigned int i = 1; i < _original_args.size (); ++i)
for (std::size_t i = 1; i < _original_args.size (); ++i)
{
bool quoted = Lexer::wasQuoted (_original_args[i].attribute ("raw"));
@ -1026,7 +1026,7 @@ void CLI2::parenthesizeOriginalFilter ()
// Locate the first and last ORIGINAL FILTER args.
unsigned int firstOriginalFilter = 0;
unsigned int lastOriginalFilter = 0;
for (unsigned int i = 1; i < _args.size (); ++i)
for (std::size_t i = 1; i < _args.size (); ++i)
{
if (_args[i].hasTag ("FILTER") &&
_args[i].hasTag ("ORIGINAL"))
@ -1043,7 +1043,7 @@ void CLI2::parenthesizeOriginalFilter ()
lastOriginalFilter)
{
std::vector <A2> reconstructed;
for (unsigned int i = 0; i < _args.size (); ++i)
for (std::size_t i = 0; i < _args.size (); ++i)
{
if (i == firstOriginalFilter)
{
@ -2038,10 +2038,10 @@ void CLI2::defaultCommand ()
reconstructed.push_back (cmd);
}
for (unsigned int i = 1; i < _original_args.size (); ++i)
for (std::size_t i = 1; i < _original_args.size (); ++i)
reconstructedOriginals.push_back (_original_args[i]);
for (unsigned int i = 1; i < _args.size (); ++i)
for (std::size_t i = 1; i < _args.size (); ++i)
reconstructed.push_back (_args[i]);
_original_args = reconstructedOriginals;