From 55c02f5420f43b57d0532ce34d1740c49c011eae Mon Sep 17 00:00:00 2001
From: Tobias Predel <tobias.predel@gmail.com>
Date: Sat, 1 Mar 2025 16:42:40 +0100
Subject: [PATCH] Remove unused includes (#3795)

* Remove unused include in Variant.h

* Remove unused include in util.h

* Remove unused include directives in util.cpp

* Remove unused include directives in TF2.h

* Remove unused include directives in TF2.cpp

* Remove unused include directive in TDB2.h

* Remove unused include directives in TDB2.cpp

* Remove unused include directives in Task.h

* Remove unused include directive in rules.cpp

* Remove unused include directives in rules.cpp

* Remove unused include directives in nag.cpp

* Remove unused include directive in main.h

* Remove unused include directive in legacy.cpph

* Remove unused include directive in Hooks.cpp

* Remove unused include directive in Filter.h

* Remove unused include directive in Filter.cpp

* Remove unused include directive in feedback.cpp

* Remove unused include directive in Eval.cpp

* Remove unused include directives in dependency.cpp

* Remove unused include directivess in Context.cpp
---
 src/Context.cpp    | 3 ---
 src/Eval.cpp       | 1 -
 src/Filter.cpp     | 2 --
 src/Filter.h       | 1 -
 src/Hooks.cpp      | 1 -
 src/TDB2.cpp       | 3 ---
 src/TDB2.h         | 1 -
 src/TF2.cpp        | 8 --------
 src/TF2.h          | 3 ---
 src/Task.h         | 1 -
 src/Variant.h      | 1 -
 src/dependency.cpp | 2 --
 src/feedback.cpp   | 2 --
 src/legacy.cpp     | 1 -
 src/main.h         | 1 -
 src/nag.cpp        | 6 ------
 src/recur.cpp      | 7 -------
 src/rules.cpp      | 1 -
 src/util.cpp       | 7 -------
 src/util.h         | 1 -
 20 files changed, 53 deletions(-)

diff --git a/src/Context.cpp b/src/Context.cpp
index 611cbdf4c..ab5a8910c 100644
--- a/src/Context.cpp
+++ b/src/Context.cpp
@@ -40,12 +40,10 @@
 #include <rust/cxx.h>
 #include <shared.h>
 #include <stdlib.h>
-#include <string.h>
 #include <taskchampion-cpp/lib.h>
 #include <unistd.h>
 
 #include <algorithm>
-#include <fstream>
 #include <iomanip>
 #include <iostream>
 #include <regex>
@@ -55,7 +53,6 @@
 #include <commit.h>
 #endif
 
-#include <stdio.h>
 #include <sys/ioctl.h>
 
 #ifdef SOLARIS
diff --git a/src/Eval.cpp b/src/Eval.cpp
index 5b869061e..7d82224ab 100644
--- a/src/Eval.cpp
+++ b/src/Eval.cpp
@@ -34,7 +34,6 @@
 #include <Task.h>
 #include <format.h>
 #include <shared.h>
-#include <time.h>
 
 #include <map>
 
diff --git a/src/Filter.cpp b/src/Filter.cpp
index 0de77e88d..2e6d20a00 100644
--- a/src/Filter.cpp
+++ b/src/Filter.cpp
@@ -36,8 +36,6 @@
 #include <format.h>
 #include <shared.h>
 
-#include <algorithm>
-
 ////////////////////////////////////////////////////////////////////////////////
 // Take an input set of tasks and filter into a subset.
 void Filter::subset(const std::vector<Task>& input, std::vector<Task>& output) {
diff --git a/src/Filter.h b/src/Filter.h
index 2c47da6c4..bb7449318 100644
--- a/src/Filter.h
+++ b/src/Filter.h
@@ -30,7 +30,6 @@
 #include <Task.h>
 #include <Variant.h>
 
-#include <string>
 #include <vector>
 
 class Filter {
diff --git a/src/Hooks.cpp b/src/Hooks.cpp
index a8ad76b82..a703b2539 100644
--- a/src/Hooks.cpp
+++ b/src/Hooks.cpp
@@ -44,7 +44,6 @@
 #include <Variant.h>
 #include <format.h>
 #include <shared.h>
-#include <stdio.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
diff --git a/src/TDB2.cpp b/src/TDB2.cpp
index 227e22965..08db87ddc 100644
--- a/src/TDB2.cpp
+++ b/src/TDB2.cpp
@@ -35,14 +35,11 @@
 #include <format.h>
 #include <main.h>
 #include <shared.h>
-#include <signal.h>
 #include <stdlib.h>
 #include <util.h>
 
 #include <algorithm>
 #include <iostream>
-#include <list>
-#include <sstream>
 #include <unordered_set>
 #include <vector>
 
diff --git a/src/TDB2.h b/src/TDB2.h
index 1720cf9ba..89b5ae8e8 100644
--- a/src/TDB2.h
+++ b/src/TDB2.h
@@ -29,7 +29,6 @@
 
 #include <FS.h>
 #include <Task.h>
-#include <stdio.h>
 #include <taskchampion-cpp/lib.h>
 
 #include <map>
diff --git a/src/TF2.cpp b/src/TF2.cpp
index 9b7e2f940..6ab74c24d 100644
--- a/src/TF2.cpp
+++ b/src/TF2.cpp
@@ -33,16 +33,8 @@
 #include <format.h>
 #include <main.h>
 #include <shared.h>
-#include <signal.h>
-#include <stdlib.h>
 #include <util.h>
 
-#include <algorithm>
-#include <iostream>
-#include <list>
-#include <set>
-#include <sstream>
-
 #define STRING_TDB2_REVERTED "Modified task reverted."
 
 ////////////////////////////////////////////////////////////////////////////////
diff --git a/src/TF2.h b/src/TF2.h
index fbec1f12b..14f0f2485 100644
--- a/src/TF2.h
+++ b/src/TF2.h
@@ -29,12 +29,9 @@
 
 #include <FS.h>
 #include <Task.h>
-#include <stdio.h>
 
 #include <map>
 #include <string>
-#include <unordered_map>
-#include <unordered_set>
 #include <vector>
 
 // TF2 Class represents a single 2.x-style file in the task database.
diff --git a/src/Task.h b/src/Task.h
index 66e18b13b..b430a2bc2 100644
--- a/src/Task.h
+++ b/src/Task.h
@@ -30,7 +30,6 @@
 #include <Datetime.h>
 #include <JSON.h>
 #include <Table.h>
-#include <stdio.h>
 #include <taskchampion-cpp/lib.h>
 #include <time.h>
 
diff --git a/src/Variant.h b/src/Variant.h
index 3cbc5c6af..735779136 100644
--- a/src/Variant.h
+++ b/src/Variant.h
@@ -30,7 +30,6 @@
 #include <Task.h>
 #include <time.h>
 
-#include <map>
 #include <string>
 
 class Variant {
diff --git a/src/dependency.cpp b/src/dependency.cpp
index 28b592470..8ac462aff 100644
--- a/src/dependency.cpp
+++ b/src/dependency.cpp
@@ -32,9 +32,7 @@
 #include <main.h>
 #include <shared.h>
 
-#include <algorithm>
 #include <iostream>
-#include <sstream>
 #include <stack>
 
 #define STRING_DEPEND_BLOCKED "Task {1} is blocked by:"
diff --git a/src/feedback.cpp b/src/feedback.cpp
index 22b9f9dc5..0fc7b84fc 100644
--- a/src/feedback.cpp
+++ b/src/feedback.cpp
@@ -32,12 +32,10 @@
 #include <Duration.h>
 #include <Lexer.h>
 #include <format.h>
-#include <inttypes.h>
 #include <main.h>
 #include <shared.h>
 #include <stdlib.h>
 
-#include <algorithm>
 #include <iostream>
 #include <sstream>
 #include <string>
diff --git a/src/legacy.cpp b/src/legacy.cpp
index 16b1f3292..a14be7f2f 100644
--- a/src/legacy.cpp
+++ b/src/legacy.cpp
@@ -30,7 +30,6 @@
 #include <Context.h>
 #include <format.h>
 
-#include <cstddef>
 #include <sstream>
 
 #define STRING_LEGACY_PRIORITY "Legacy attribute found.  Please change '{1}' to '{2}'."
diff --git a/src/main.h b/src/main.h
index 9220a1345..c08f159a7 100644
--- a/src/main.h
+++ b/src/main.h
@@ -32,7 +32,6 @@
 #include <Datetime.h>
 #include <sys/types.h>
 
-#include <algorithm>
 #include <list>
 #include <map>
 #include <optional>
diff --git a/src/nag.cpp b/src/nag.cpp
index 057567582..356287f45 100644
--- a/src/nag.cpp
+++ b/src/nag.cpp
@@ -25,15 +25,9 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 #include <cmake.h>
-
-#include <algorithm>
 // cmake.h include header must come first
-
 #include <Context.h>
 
-#include <iterator>
-#include <unordered_set>
-#include <utility>
 #include <vector>
 
 ////////////////////////////////////////////////////////////////////////////////
diff --git a/src/recur.cpp b/src/recur.cpp
index 4168b6691..857273926 100644
--- a/src/recur.cpp
+++ b/src/recur.cpp
@@ -32,24 +32,17 @@
 #include <Duration.h>
 #include <Lexer.h>
 #include <format.h>
-#include <inttypes.h>
 #include <main.h>
 #include <pwd.h>
-#include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 #include <sys/types.h>
 #include <time.h>
 #include <unicode.h>
 #include <unistd.h>
 #include <util.h>
 
-#include <fstream>
-#include <iomanip>
-#include <iostream>
 #include <limits>
 #include <optional>
-#include <sstream>
 
 // Add a `time_t` delta to a Datetime, checking for and returning nullopt on integer overflow.
 std::optional<Datetime> checked_add_datetime(Datetime& base, time_t delta) {
diff --git a/src/rules.cpp b/src/rules.cpp
index 924644233..6843db465 100644
--- a/src/rules.cpp
+++ b/src/rules.cpp
@@ -31,7 +31,6 @@
 #include <Datetime.h>
 #include <main.h>
 #include <shared.h>
-#include <stdlib.h>
 
 static std::map<std::string, Color> gsColor;
 static std::vector<std::string> gsPrecedence;
diff --git a/src/util.cpp b/src/util.cpp
index 04593791f..78174028b 100644
--- a/src/util.cpp
+++ b/src/util.cpp
@@ -38,10 +38,7 @@
 #include <main.h>
 #include <pwd.h>
 #include <signal.h>
-#include <stdint.h>
-#include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 #include <sys/select.h>
 #include <sys/time.h>
 #include <sys/types.h>
@@ -51,11 +48,7 @@
 #include <utf8.h>
 #include <util.h>
 
-#include <algorithm>
-#include <cstring>
-#include <fstream>
 #include <iostream>
-#include <sstream>
 #include <string>
 #include <vector>
 
diff --git a/src/util.h b/src/util.h
index a4f94a1a9..782311117 100644
--- a/src/util.h
+++ b/src/util.h
@@ -32,7 +32,6 @@
 
 #include <sys/types.h>
 
-#include <map>
 #include <string>
 #include <vector>
 #if defined(FREEBSD) || defined(OPENBSD)