GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Cleanup

Browse source 
- Eliminated text.cpp upperCase(), as it was not UTF8-safe, and is no longer
  used.
This commit is contained in:
Paul Beckingham 2015-02-17 10:44:31 -05:00
parent 693fe9b8fd
commit 520067f522
4 changed files with 3 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -1,5 +1,7 @@
2.4.2 () - 2.4.2 () -
- Eliminated some code that is not UTF8-safe.
------ current release --------------------------- ------ current release ---------------------------
2.4.1 (2015-02-16) 82e019a4a8b20de63d53b51d59b8d1c89d3c05b2 2.4.1 (2015-02-16) 82e019a4a8b20de63d53b51d59b8d1c89d3c05b2

8
src/text.cpp
View file

@ -424,14 +424,6 @@ std::string lowerCase (const std::string& input)
return output; return output;
} }
////////////////////////////////////////////////////////////////////////////////
std::string upperCase (const std::string& input)
{
std::string output = input;
std::transform (output.begin (), output.end (), output.begin (), toupper);
return output;
}
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
std::string ucFirst (const std::string& input) std::string ucFirst (const std::string& input)
{ {

1
src/text.h
View file

@ -45,7 +45,6 @@ void join (std::string&, const std::string&, const std::vector<std::string>&);
void join (std::string&, const std::string&, const std::vector<int>&); void join (std::string&, const std::string&, const std::vector<int>&);
std::string commify (const std::string&); std::string commify (const std::string&);
std::string lowerCase (const std::string&); std::string lowerCase (const std::string&);
std::string upperCase (const std::string&);
std::string ucFirst (const std::string&); std::string ucFirst (const std::string&);
const std::string str_replace (std::string&, const std::string&, const std::string&); const std::string str_replace (std::string&, const std::string&, const std::string&);
const std::string str_replace (const std::string&, const std::string&, const std::string&); const std::string str_replace (const std::string&, const std::string&, const std::string&);

6
test/text.t.cpp
View file

@ -37,7 +37,7 @@ Context context;
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
int main (int argc, char** argv) int main (int argc, char** argv)
{ {
UnitTest t (216); UnitTest t (214);
// Ensure environment has no influence. // Ensure environment has no influence.
unsetenv ("TASKDATA"); unsetenv ("TASKDATA");
@ -279,10 +279,6 @@ int main (int argc, char** argv)
t.is (lowerCase (""), "", "lowerCase '' -> ''"); t.is (lowerCase (""), "", "lowerCase '' -> ''");
t.is (lowerCase ("pre01_:POST"), "pre01_:post", "lowerCase 'pre01_:POST' -> 'pre01_:post'"); t.is (lowerCase ("pre01_:POST"), "pre01_:post", "lowerCase 'pre01_:POST' -> 'pre01_:post'");
// std::string upperCase (const std::string& input)
t.is (upperCase (""), "", "upperCase '' -> ''");
t.is (upperCase ("pre01_:POST"), "PRE01_:POST", "upperCase 'pre01_:POST' -> 'PRE01_:POST'");
// bool nontrivial (const std::string&); // bool nontrivial (const std::string&);
t.notok (nontrivial (""), "nontrivial '' -> false"); t.notok (nontrivial (""), "nontrivial '' -> false");
t.notok (nontrivial (" "), "nontrivial ' ' -> false"); t.notok (nontrivial (" "), "nontrivial ' ' -> false");